search

wutong16 / Voxurf

[ ICLR 2023 Spotlight ] Pytorch implementation for "Voxurf: Voxel-based Efficient and Accurate Neural Surface Reconstruction"
Other
399 stars 28 forks source link

Make paths OS-agnostic #7

Closed MvWouden closed 1 year ago

MvWouden commented 1 year ago

To allow the code to be OS-agnostic (e.g. non-wsl Windows users can use it as well), I propose a few small changes:

  1. Change all hard-coded paths with forward slashes to use os.path.join.
  2. Change the Unix-style cp and rm commands to use built-in python methods (shutil or os).
  3. Add .bat scripts for Windows alongside the already existing .sh scripts.

Please let me know how you feel about this. I'd be willing to make some more changes if required. If you could, it would be nice if you can run the code once (e.g on Unix) to see that everything still works as expected.

wutong16 commented 1 year ago

Thank you for your help in making the code OS-agnostic!

MvWouden commented 1 year ago

Thank you for your help in making the code OS-agnostic!

@wutong16 Did you happen to test out the changes already?

wutong16 commented 1 year ago

Yes. The code runs correctly on my Linux with the changes above (after adding an import os) :D.