wuvt / donormotor

WUVT's new donation management and donor-relations platform.
GNU Affero General Public License v3.0
5 stars 0 forks source link

GUI to enable radiothon mode #36

Closed echarlie closed 3 years ago

echarlie commented 4 years ago

currently, it's a bool set in Redis. It should be simple to add a button or timer to the admin interface

mutantmonkey commented 4 years ago

@Giggybyte was working on adding this: https://github.com/wuvt/wuvt-site/tree/sitesettings

g-i-g commented 4 years ago

here's a screenshot of what I had done at the time: https://i.imgur.com/R4QPcDE.png

y'all can see the same by checking out the sitesettings branch and following the usual instructions for a local docker deployment as described in the readme. I barely remember writing this tbh, but it does appear to work

couple of ideas for improvement:

  1. add some sort of confirmation (e.g. "Are you sure you want to enable/disable Radiothon mode?") after clicking Save Changes
  2. something nicer visually (if deemed necessary)
mutantmonkey commented 4 years ago

Thanks for the screenshot!

I don't think the confirmation is necessary, this is easy to undo. As far as visual improvements, I don't like having the bullets next to the radio buttons, I think it looks messy...I'm really surprised that's the default with WTForms.

That being said, feel free to open a PR...we can always get this in and make it look nicer later on.

echarlie commented 4 years ago

if there's some sort of slider toggle (à la apple iOS), I think that would be a better look; e.g. http://www.bootstraptoggle.com/ (it wraps some jquery around a checkbox)

g-i-g commented 4 years ago

would you still want a Save Changes button with the slider toggle? I'm just worried that someone may accidentally flick it on or off if it's a one-click action to toggle radiothon, but maybe I'm just being paranoid

mutantmonkey commented 4 years ago

I think it would probably be better without one. If we're worried about someone accidentally toggling it, that might be a good case for a confirmation dialog like you suggested. But again, it's an easy change to undo since all it does is toggle a boolean, so even if someone does accidentally toggle it, it's not a big deal.

echarlie commented 4 years ago

I think toggling it is a non-issue.