wuvt / trackman

WUVT's track logging web-app
GNU Affero General Public License v3.0
4 stars 3 forks source link

DJs should have a show name field in trackman #5

Open echarlie opened 6 years ago

echarlie commented 6 years ago

From @matthazinski on March 8, 2015 2:31

A better unique identifier for trackman users is show name rather than DJ name, as DJs may want to have multiple shows with different themes. We should also enforce uniqueness for show name.

Copied from original issue: wuvt/wuvt-site#78

echarlie commented 6 years ago

From @telnoratti on March 8, 2015 4:33

This probably depends on an interface to edit your DJ information since there are already entered DJs. I'm not sure how the relation between show name and DJ should be with respect to logging into a site. Would I login as the DJ, then select the show to play?

echarlie commented 6 years ago

From @matthazinski on March 8, 2015 4:41

No, you would login as a show.

echarlie commented 6 years ago

From @telnoratti on March 8, 2015 4:43

So every time I want to do a new show I would register a new DJ?

echarlie commented 6 years ago

From @matthazinski on March 8, 2015 4:45

Yes, with the assumption that a schedule spot would always correspond to the same show (assuming the DJ shows up)

echarlie commented 6 years ago

From @telnoratti on March 8, 2015 4:49

Okay sounds good, maybe we should change some of the wording to reflect that they're creating a show, not a DJ. For example instead of "Register DJ" say "Register Show"

echarlie commented 6 years ago

From @telnoratti on March 8, 2015 20:48

Should we use DJ name for anything? I assume people still want to be known by their DJ name.

A list of everywhere in the code as of c1e539fc5 this shows up and needs to be considered.

./wuvt/trackman/lib.py:40:    msg['To'] = djset.dj.email
./wuvt/trackman/lib.py:45:        djname=djset.dj.airname,
./wuvt/trackman/views.py:30:        data['dj'] = dj.airname
./wuvt/trackman/views.py:33:        data['dj'] = track.djset.dj.airname
./wuvt/templates/trackman/log.html:10:        <h1>{{ trackman_name }}: {{ djset.dj.airname }}</h1>
./wuvt/templates/trackman/edit.html:6:        <h1>Edit Track: {{ track.djset.dj.airname }}</h1>
./wuvt/templates/trackman/login.html:13:            <option value="{{ dj.id }}">{{ dj.airname }}
./wuvt/templates/email/playlist.txt:1:Your playlist: {{ djset.dj.airname }} / {{ djset.dtstart|datetime("%Y-%m-%d %H:%M") }}
./wuvt/templates/email/playlist.html:5:    <title>Your playlist: {{ djset.dj.airname }}</title>
./wuvt/templates/email/playlist.html:8:    <h1>Your playlist: {{ djset.dj.airname }} /
./wuvt/templates/playlists_dj_sets.html:2:{% block title %}{{ dj.airname }} - Playlist Archive (by DJ) - {{ super() }}{% endblock %}
./wuvt/templates/playlists_dj_sets.html:8:    <h3>{{ dj.airname }}</h3>
./wuvt/templates/last15.html:31:                {% if track.dj.visible -%} 
./wuvt/templates/last15.html:32:                <a href="{{ url_for('playlists_dj_sets', dj_id=track.dj_id) }}">{{ track.dj.airname }}</a>
./wuvt/templates/last15.html:34:                {{ track.dj.airname }}
./wuvt/templates/playlist.html:2:{% block title %}{{ djset.dtstart|datetime("%Y-%m-%d %H:%M") }} - {{ djset.dj.airname }} - Playlist Archive - {{ super() }}{% endblock %}
./wuvt/templates/playlist.html:10:    <h3>{{ djset.dj.airname }} / {{ djset.dtstart|datetime("%Y-%m-%d %H:%M") }}</h3>
./wuvt/templates/playlists_date_sets.html:14:        <li><a href="{{ url_for('playlist', set_id=set.id) }}">{{ set.dtstart|datetime("%H:%S") }}-{{ set.dtend|datetime("%H:%S") }} {{ set.dj.airname }}</a></li>
./wuvt/templates/playlists_dj_list.html:13:        <li><a href="{{ url_for('playlists_dj_sets', dj_id=dj.id) }}">{{ dj.airname }}</a></li>
echarlie commented 6 years ago

From @matthazinski on March 8, 2015 20:54

I just realized not everyone has a show name. Maybe we should support a blank show name field and show the DJ name field instead in that case?

echarlie commented 6 years ago

From @telnoratti on March 8, 2015 20:59

What about playlist by DJ or by Show? DJs may want to change their show e.g. from Americana to Metal. Changing the show name will have lots of playlists listed under that show name.

echarlie commented 6 years ago

From @matthazinski on March 9, 2015 0:30

Moving to 'maybe' since I'd like to hash out the design more before starting

mutantmonkey commented 4 years ago

As suggested in https://github.com/wuvt/trackman/issues/107#issuecomment-656963133, we may also want to have a way to do one-off show name overrides for things like radiothon and whatnot.