search

wuvt / wuvt-site

Website including a CMS, playlist information, and donation management tools
https://www.wuvt.vt.edu
GNU Affero General Public License v3.0
11 stars 12 forks source link

Donation improvements #385

Closed echarlie closed 3 years ago

echarlie commented 3 years ago

fixes #278 partially resolves #220

echarlie commented 3 years ago

interesting quirk. We don't have any DB constraints that would cause this problem, do we?

mutantmonkey commented 3 years ago

Not that I can think of...

mutantmonkey commented 3 years ago

Okay, I think this is why:

    def set_shipped(self, shipped_date=None):
        if self.premiums is not None:

If premiums is None, set_shipped does nothing; in this case, we should hide the "Set as Shipped" button.

Looks good otherwise, this will be a great improvement.

echarlie commented 3 years ago

discussion should continue in wuvt/donormotor#22