wuxudong / react-native-charts-wrapper

a react native charts wrapper (support android & iOS)
2.43k stars 657 forks source link

add minOffset to bar chart #979

Open philipheinser opened 8 months ago

philipheinser commented 8 months ago

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch react-native-charts-wrapper@0.6.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartManagerBridge.h b/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartManagerBridge.h
index 4737c70..bdd1069 100644
--- a/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartManagerBridge.h
+++ b/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartManagerBridge.h
@@ -28,6 +28,7 @@ RCT_EXPORT_VIEW_PROPERTY(doubleTapToZoomEnabled, BOOL) \
 RCT_EXPORT_VIEW_PROPERTY(zoom, NSDictionary) \
 RCT_EXPORT_VIEW_PROPERTY(viewPortOffsets, NSDictionary) \
 RCT_EXPORT_VIEW_PROPERTY(extraOffsets, NSDictionary) \
+RCT_EXPORT_VIEW_PROPERTY(minOffset, NSNumber) \
 RCT_EXPORT_VIEW_PROPERTY(onYaxisMinMaxChange, RCTBubblingEventBlock) \
 RCT_EXTERN_METHOD(moveViewToX:(nonnull NSNumber *)node xValue:(nonnull NSNumber *)xValue) \
 RCT_EXTERN_METHOD(moveViewTo:(nonnull NSNumber *)node xValue:(nonnull NSNumber *)xValue yValue:(nonnull NSNumber *)yValue axisDependency:(nonnull NSString *)axisDependency) \
diff --git a/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartViewBase.swift b/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartViewBase.swift
index a1fd7d5..631b73e 100644
--- a/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartViewBase.swift
+++ b/node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/RNBarLineChartViewBase.swift
@@ -233,6 +233,10 @@ class RNBarLineChartViewBase: RNYAxisChartViewBase {
         barLineChart.setExtraOffsets(left: left, top: top, right: right, bottom: bottom)
     }

+    func setMinOffset(_ config: NSNumber) {
+        barLineChart.minOffset = CGFloat(config.doubleValue);
+    }
+
     override func onAfterDataSetChanged() {
         super.onAfterDataSetChanged()

This issue body was partially generated by patch-package.