search

wuyuntao / jquery-autosuggest

A fork of AutoSuggest jQuery plugin writtern by Drew Wilson.
http://github.com/wuyuntao/jquery-autosuggest
118 stars 59 forks source link

Overall maintaining status #25

Closed knalli closed 9 years ago

knalli commented 12 years ago

Hi,

I'd sent you a mail a few days ago using the profile's mail address. Seems not to be reliable.

I'm interested in your further plans about this project. Do you want to maintain it, or is that out of scope?

We had chosen that plugin (formely the 1.4er of Drew Wilson) for our application. Still in developing, we had noticed few weeks ago that the plugin is extremly unsafe in context of some issues with XSS (cross site scripting). Even on Drew Wilson website I can inject JavaScript easily.

Actually, this is already fixed in our own topic branch at https://github.com/hlsolutions/jquery-autosuggest/tree/advanced-rendering-and-xss-protection, but I'm waiting for the other PR.

If you are out of time or have don't like it to maintain further, I won't provide the pull requests. In that case, I would ask the outstanding PRs to re-integrate a patch for me..

best regards, Jan

wuyuntao commented 12 years ago

Sorry for late response. This project is still alive and feel free to open a pull request.

knalli commented 12 years ago

Hm, okay. However, actually, there are still a couple of open requests without any further reactions. Don't get me wrong, but I'm just surveying how to handle the changes.

knalli commented 12 years ago

So, three months went away.

In the meantime, I released yesterday the next release of AutoSuggest 2 at https://github.com/hlsolutions/jquery-autosuggest/. The big change is the transition to CoffeeScript and SASS in combination to Grunt and post commit tests with Travis. Please note the changelog because some events had been renamed.

Everyone is invited to send us PRs if you want.