wuzhzn / pe

0 stars 0 forks source link

Large positive numbers in the number field are not allowed #4

Open wuzhzn opened 1 year ago

wuzhzn commented 1 year ago

image.png

Large positive numbers are not detected as numbers, but a number flag is set to be between 1 and 10000.

nus-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Large positive numbers in the number field are not allowed

image.png

Large positive numbers in the flags that require numbers are not detected as numbers. This occurs in most of the commands that require some form of numbers. e.g. add, remove, recipe need , make, recipe favourite, recipe unfavourite


[original: nus-cs2113-AY2223S2/pe-interim#819] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Downgraded to very low because incorrect error message is a typo/cosmetic issue

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** The amount field is an int, which would only accept numbers up to 2147483647. Any number greater than that would not be registered as a number. Therefore it returned a different message from the one that allows numbers from 1-10000. This is not just a cosmetic issue since it can affect the user experience. For instance, the label on salt is grammes, and a user might have 3 thousand tonnes of salt, which would exceed the number accepted by int. ![image.png](https://raw.githubusercontent.com/wuzhzn/pe/main/files/eb24b516-1f31-493f-867b-6a84756202c0.png)