wuzhzn / pe

0 stars 0 forks source link

Large positive numbers in the number field are not allowed #5

Open wuzhzn opened 1 year ago

wuzhzn commented 1 year ago

image.png

Large positive numbers in the flags that require numbers are not detected as numbers. This occurs in most of the commands that require some form of numbers. e.g. add, remove, recipe need , make, recipe favourite, recipe unfavourite

nus-pe-bot commented 1 year ago

Team's Response

Downgraded to very low because incorrect error message is a typo/cosmetic issue

Items for the Tester to Verify

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/wuzhzn/pe/main/files/83b921bd-e5f3-42a7-9f25-f1d75e291f51.png) The amount field is an int, which would only accept numbers up to 2147483647. Any number greater than that would not be registered as a number. Therefore it returned a different message from the one that allows numbers from 1-10000. This is not just a cosmetic issue and it can affect the user experience. For instance, the label on salt is grammes, and a user might have 3 thousand tonnes of salt, which would exceed the number accepted by int.