Bugfix: make decoding_palette and transparent_color variables that get passed along instead of instance variables.

wvanbergen / chunky_png

Read/write access to PNG images in pure Ruby.

https://chunkypng.com

MIT License

1.05k stars 101 forks source link

Bugfix: make decoding_palette and transparent_color variables that get passed along instead of instance variables. #112

Closed wvanbergen closed 8 years ago

wvanbergen commented 8 years ago

Make decoding_palette and transparent_color instance variables of the canvas instead of of the Canvas class.

This should make it thread-safe, and allows you to decode multiple images simultaneously.
This should prevent lingering state from messing up subsequent image decodes.

Should fix #58. Thanks to @jhamon for finding the cause of this.

wvanbergen commented 8 years ago

@lencioni any chance you can look at this to see if it makes sense?

lencioni commented 8 years ago

This makes sense to me and I like the more functional approach. However, these aren't instance variables, they are local variables, so you might want to update your commit message.