search

wvanbergen / chunky_png

Read/write access to PNG images in pure Ruby.
https://chunkypng.com
MIT License
1.05k stars 101 forks source link

Dependency on RMagick is unclear #90

Closed chrisseaton closed 9 years ago

chrisseaton commented 9 years ago

Chunky PNG seems to have a dependency on RMagick in https://github.com/wvanbergen/chunky_png/blob/master/lib/chunky_png/rmagick.rb#L1. It's also used in the specs https://github.com/wvanbergen/chunky_png/blob/master/spec/chunky_png/rmagick_spec.rb.

However I can't find any dependency on it in the gemspec. When I bundle install it doesn't appear in the Gemfile.lcok either.

wvanbergen commented 9 years ago

This is by design - I don't want RMagick to be installed when people install ChunkyPNG. Many people use ChunkyPNG especially because they don't need RMagick anymore.

The chunky_png/rmagick file is included to make interoperability between the two libraries easier. It is not required by default, and people that use it should already have RMagick in them Gemfile.

Potentially we should add it as a development dependency to the gemspec so we can run the interoperability specs as part of the test runs,. but this is not a high priority for me.

chrisseaton commented 9 years ago

You could install RMagick on Travis before you run there - otherwise these specs aren't being in CI are they?

wvanbergen commented 9 years ago

Yup, that would be a nice improvement for the test setup. :+1: