Sort instance list before running distribution

wvanbergen / kafka-consumer

High-level Ruby consumer for Kafka.

MIT License

12 stars 10 forks source link

Sort instance list before running distribution #4

Open mlispokeo opened 9 years ago

mlispokeo commented 9 years ago

Sort the list of instance to make sure all instances get the same order when running distribution algorithm. Otherwise, distribution will probably conflict among running instances.

mclark commented 9 years ago

:+1: I think this is the cause of some problems I've been seeing. Please review and merge!

mclark commented 9 years ago

Can confirm, this PR fixed all my rebalancing issues. Anyone using this gem should just use this branch. Thanks @mlispokeo!

mlispokeo commented 9 years ago

No problem@mclark ! I'm happy to contribute, though this repo is out of maintenance for quite a long time already.