search

wvanbergen / kafka

Load-balancing, resuming Kafka consumer for go, backed by Zookeeper.
MIT License
373 stars 141 forks source link

break waiting for claiming partition if new consumer join #113

Closed mrcold closed 6 years ago

mrcold commented 7 years ago

With PR #101 , I still run into some issues. When a consumer is looping 62s for the previous partition owner to release it, some new consumer may join, so the all of the assignment will be calculated again.

In this case, it make no sense to waiting for the partition calculated based-on the old consumer list. It should break the waiting loop and trying to claim all of the new assigned partitions.

elaPa commented 6 years ago

We're experiencing the same issue, and the PR proposed here fixes it (thank you, @mrcold !) @wvanbergen could you take a look at accepting this change, please? Thank you!

wvanbergen commented 6 years ago

Thanks!

elaPa commented 6 years ago

Thank you!