search

wvanbergen / kazoo-go

Go library to access Kafka metadata in Zookeeper
http://godoc.org/github.com/wvanbergen/kazoo-go
MIT License
100 stars 48 forks source link

Create and delete topics #25

Closed F21 closed 6 years ago

F21 commented 8 years ago

Trying to carry #20.

F21 commented 8 years ago

ping @wvanbergen Can you merge this? Carried #20 and got the tests passing.

wvanbergen commented 8 years ago

Can you rebase this pull request? This PR includes a bunch of stuff that was already merged to master. :/

F21 commented 8 years ago

@wvanbergen Good catch. I think I initially rebased against the wrong master. Just waiting for the tests to run again. Should be fine now 😄

F21 commented 8 years ago

Address your comments in the new commit! 😄

F21 commented 8 years ago

@wvanbergen All comments addressed! 👍

F21 commented 8 years ago

@wvanbergen Any chance you can take another look at this?

efeller commented 7 years ago

Any plans to merge this? Thanks.

JeanMertz commented 7 years ago

Any chance of this getting merged anytime soon? 👍

sparkLogic commented 6 years ago

@wvanbergen @F21 : Can you please rebase and merge this? Topic administration support provided by this MR is super helpful for a number of scenarios

wvanbergen commented 6 years ago

Sorry, I haven't been working on Kafka recently, so my context is starting to wane.