search

wvanbergen / kazoo-go

Go library to access Kafka metadata in Zookeeper
http://godoc.org/github.com/wvanbergen/kazoo-go
MIT License
100 stars 48 forks source link

TML-11943 Improves Kazoo logging #26

Closed F21 closed 7 years ago

F21 commented 8 years ago

Carrying #16

F21 commented 8 years ago

Tests appear to pass for this one.

wvanbergen commented 8 years ago

Any chance you can paste a sample of the logging this generates?

F21 commented 8 years ago

Unfortunately, I don't currently have an environment to set the whole thing up to test it out.

F21 commented 8 years ago

Just dug into the code for this one.

This is what the logging generates:

2016/09/30 11:19:57 Connected to 127.0.0.1:2181
2016/09/30 11:19:57 Authenticated: id=96680960823394309, timeout=6000
2016/09/30 11:19:57 Re-submitting `0` credentials after reconnect
2016/09/30 11:19:57 Recv loop terminated: err=EOF
2016/09/30 11:19:57 Send loop terminated: err=<nil>

See all the logs in the test-run on travis: https://travis-ci.org/wvanbergen/kazoo-go/jobs/163984543

The behaviour is exactly the same as the current behaviour without this change, as the zk client automatically sets the DefaultLogger as the logger if no logger is passed in. See my other PR where the zk client also logs to output, despite no logger being set: https://travis-ci.org/wvanbergen/kazoo-go/jobs/163991218

tosan88 commented 7 years ago

Hi! Any plans to release this change?

wvanbergen commented 7 years ago

Sorry for the late response. I have not been actively maintaining this library, and am working in a different field these days, so PR reviews will be slow as a result.