wvanbergen / node-vertica

Pure javascript Vertica database client. Except it is written in CoffeeScript.
MIT License
44 stars 30 forks source link

Fix statement interruption #40

Closed themadcreator closed 10 years ago

themadcreator commented 10 years ago
  1. Fix syntax for interruptStatement method to refer to correct conn object.
  2. Fix SQL statement for interruptStatement to use statementID variable (not SQL column).
  3. Add unit test to verify statement interruption.

Coffeescript modifications only. Javascript not built.

NOTE: Unfortunately, the normal testing method using SELECT SLEEP(1000) does not work since SLEEP statements are not interruptible. See connection_test.coffee for more comments.

wvanbergen commented 10 years ago

Aside from my question & nitpick, this looks good. Apparently I've never actually used this feature because the old implementation could never work.

themadcreator commented 10 years ago

Anything else I can do to help you merge this?

wvanbergen commented 10 years ago

Nope, thanks for helping out!

themadcreator commented 10 years ago

Awesome, thx!

Do you have a schedule for make releases?

I wouldn't mind referring to specific commit hash in my package.json, but since we don't recompile the javascript for PRs, I can't use these updates yet.

bd

On Fri, Oct 24, 2014 at 1:24 AM, Willem van Bergen <notifications@github.com

wrote:

Nope, thanks for helping out!

— Reply to this email directly or view it on GitHub https://github.com/wvanbergen/node-vertica/pull/40#issuecomment-60358182 .

wvanbergen commented 10 years ago

I’ll do a release this weekend.

On Oct 24, 2014, at 2:33 PM, Bill Dwyer notifications@github.com wrote:

Awesome, thx!

Do you have a schedule for make releases?

I wouldn't mind referring to specific commit hash in my package.json, but since we don't recompile the javascript for PRs, I can't use these updates yet.

bd

On Fri, Oct 24, 2014 at 1:24 AM, Willem van Bergen <notifications@github.com

wrote:

Nope, thanks for helping out!

— Reply to this email directly or view it on GitHub https://github.com/wvanbergen/node-vertica/pull/40#issuecomment-60358182 .

— Reply to this email directly or view it on GitHub.

themadcreator commented 10 years ago

That would be tremendously helpful, thanks!

bd

On Fri, Oct 24, 2014 at 11:37 AM, Willem van Bergen < notifications@github.com> wrote:

I’ll do a release this weekend.

On Oct 24, 2014, at 2:33 PM, Bill Dwyer notifications@github.com wrote:

Awesome, thx!

Do you have a schedule for make releases?

I wouldn't mind referring to specific commit hash in my package.json, but since we don't recompile the javascript for PRs, I can't use these updates yet.

bd

On Fri, Oct 24, 2014 at 1:24 AM, Willem van Bergen < notifications@github.com

wrote:

Nope, thanks for helping out!

— Reply to this email directly or view it on GitHub < https://github.com/wvanbergen/node-vertica/pull/40#issuecomment-60358182> .

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/wvanbergen/node-vertica/pull/40#issuecomment-60430521 .

wvanbergen commented 10 years ago

Released 0.5.2

On Oct 24, 2014, at 2:38 PM, Bill Dwyer notifications@github.com wrote:

That would be tremendously helpful, thanks!

bd

On Fri, Oct 24, 2014 at 11:37 AM, Willem van Bergen < notifications@github.com> wrote:

I’ll do a release this weekend.

On Oct 24, 2014, at 2:33 PM, Bill Dwyer notifications@github.com wrote:

Awesome, thx!

Do you have a schedule for make releases?

I wouldn't mind referring to specific commit hash in my package.json, but since we don't recompile the javascript for PRs, I can't use these updates yet.

bd

On Fri, Oct 24, 2014 at 1:24 AM, Willem van Bergen < notifications@github.com

wrote:

Nope, thanks for helping out!

— Reply to this email directly or view it on GitHub < https://github.com/wvanbergen/node-vertica/pull/40#issuecomment-60358182> .

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/wvanbergen/node-vertica/pull/40#issuecomment-60430521 .

— Reply to this email directly or view it on GitHub https://github.com/wvanbergen/node-vertica/pull/40#issuecomment-60430677.