Supporting TLSSocket for Node 12.x or higher

kefon94 commented 3 years ago

Supporting TLSSocket for Node 12.x or higher

Issue

fix https://github.com/wvanbergen/node-vertica/issues/64 createSecurePair is not longer supported on Node version 12.x or higher. The issue was difficult to find because of there isn't an error / exception thrown by this code.

Solution

Ask if TLSSocket exists and use it, if not then use createSecurePair for Node JS version 0.11.
The event listener called _tlsError was added in order to let devs know any issue with the connection to troubleshoot.
Some common code that was the pipe function was added to the main function . The pipe function keeps only the old implementation it needs for createSecurePair

hulmgulm commented 3 years ago

Which issue do you want to solve with this change? We're using this library with Node 14 and TLS works fine.

hulmgulm-at-work commented 3 years ago

Which issue do you want to solve with this change? We're using this library with Node 14 and TLS works fine.

Ok, digging deeper into it I understand now. Secure Pair is long deprecated in NodeJS and should be replaced by TLSSocket.

kefon94 commented 3 years ago

Which issue do you want to solve with this change? We're using this library with Node 14 and TLS works fine.

Ok, digging deeper into it I understand now. Secure Pair is long deprecated in NodeJS and should be replaced by TLSSocket.

Hi @hulmgulm-at-work , I have added a better description of the issue, any other comment or suggest please let me know. Thanks.

wvanbergen / node-vertica