search

wvandeun / nornir_netbox

NetBox plugin for Nornir
Apache License 2.0
69 stars 17 forks source link

NetBoxInventory2 Platform normalization #12

Closed egreenspan2 closed 3 years ago

egreenspan2 commented 3 years ago

NetBoxInventory2 plugin seems to default to "name" as the "platform" field when retrieving data from NB.

Are there any objections to PR to use similar init boolean to "use_slugs" similar to NBInventory class?

use_slugs: bool = True
wvandeun commented 3 years ago

No objections, I would suggest to name the argument use_platform_slug. use_slugs doesn't make sense anymore, since we would only do it for 1 specific attribute and not for multiple.