search

wvbe / slimdom-sax-parser

Parse an XML string to a light-weight spec-compliant document object model, for browser and Node
https://www.npmjs.com/package/slimdom-sax-parser
MIT License
8 stars 5 forks source link

Please document default setting of `xmlns` option #27

Closed rrthomas closed 1 year ago

rrthomas commented 1 year ago

slimdom-sax-parser sets xmlns: true, which is undocumented, and confused me when I realised that my additionalNamespaces setting should not be working according to the saxes docs: xmlns defaults to false in saxes, and the docs say: "Of course, additionalNamespaces and resolvePrefix are used only if xmlns is true."

wvbe commented 1 year ago

Good improvement, thanks for the suggestion!

wvbe commented 1 year ago

Updated the README with a short note on this, will also be pushed to npmjs.org on the next release. I think that means the ticket is done, so I'll close it soon unless it turns out I made a boo-boo

rrthomas commented 1 year ago

LGTM, thanks!