wvdakker / gtkterm

GTKTerm: A GTK+ Serial Port Terminal
GNU General Public License v3.0
104 stars 35 forks source link

PoC Flatpak packaging #44

Open tinywrkb opened 2 years ago

tinywrkb commented 2 years ago

Here's an initial Flatpak packaging manifest for GTKTerm.
The package can easily be built with Flatpak Builder.

I quickly tested the app with USB to TTL, and as far as I can tell, it's working as expected.

The following should be handled before considering publishing via Flathub.org:

Optional changes:

Jeija commented 2 years ago

Hi @tinywrkb :wave: !

I'm certainly open to adding / improving Flatpak support and am happy for any help in that regard. Concerning the issue with the configuration file location, see my comment in #40. Since I am not too familiar with how Flatpak handles permissions: With my suggested behavior, gtkterm checks if .gtktermrc exists in $HOME before potentially creating one in $XDG_CONFIG_HOME. I am wondering if checking for existence of the configuration file in $HOME will cause any issues with Flatpak support?

tinywrkb commented 2 years ago

@Jeija thanks for solving the config file location issue.

I am wondering if checking for existence of the configuration file in $HOME will cause any issues with Flatpak support?

No, I don't see a reason why it will.

I tested fe66238bce24e923fcc4a4876296f4dde755d2cd and it works as expected.

Jeija commented 2 years ago

Thanks for taking the time to test fe66238bce24e923fcc4a4876296f4dde755d2cd! I have now merged it into the master branch.