Open tinywrkb opened 2 years ago
Hi @tinywrkb :wave: !
I'm certainly open to adding / improving Flatpak support and am happy for any help in that regard. Concerning the issue with the configuration file location, see my comment in #40.
Since I am not too familiar with how Flatpak handles permissions: With my suggested behavior, gtkterm checks if .gtktermrc
exists in $HOME
before potentially creating one in $XDG_CONFIG_HOME
. I am wondering if checking for existence of the configuration file in $HOME
will cause any issues with Flatpak support?
@Jeija thanks for solving the config file location issue.
I am wondering if checking for existence of the configuration file in $HOME will cause any issues with Flatpak support?
No, I don't see a reason why it will.
I tested fe66238bce24e923fcc4a4876296f4dde755d2cd and it works as expected.
Thanks for taking the time to test fe66238bce24e923fcc4a4876296f4dde755d2cd! I have now merged it into the master branch.
Here's an initial Flatpak packaging manifest for GTKTerm.
The package can easily be built with Flatpak Builder.
I quickly tested the app with USB to TTL, and as far as I can tell, it's working as expected.
The following should be handled before considering publishing via Flathub.org:
XDG_CONFIG_HOME
.HOME
is the worst location for a config file because it mandates the use of the--persist=.
permission, which is a bit buggy.Optional changes:
com.github.Jeija.GTKTerm.desktop
.--device=all
permission.