search

wvmoreira / jquery-numberformatter

Automatically exported from code.google.com/p/jquery-numberformatter
0 stars 0 forks source link

pollutes window object with localeGroup property #75

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
In function init() the localeGroup variable is unitialized and attaches itself 
to the window object.

Original issue reported on code.google.com by caesar...@gmail.com on 19 Dec 2012 at 9:42

GoogleCodeExporter commented 8 years ago 
Thanks for letting us know, if I understand correctly you're saying it's 
basically not an explicitly declared variable in local scope? (which makes 
sense looking at it) so it would be fixed as follows with the highlighted 
addition? -

for (var localeGroupIdx = 0; localeGroupIdx < nfAllLocales.length; 
localeGroupIdx++) {
   var localeGroup = nfAllLocales[localeGroupIdx];
   ^^^

Original comment by apar...@gmail.com on 22 Oct 2013 at 9:23

GoogleCodeExporter commented 8 years ago 
Yes, that is what I meant. Thanks for the fix.

Original comment by caesar...@gmail.com on 22 Oct 2013 at 12:35