search

wvteijlingen / Spine

A Swift library for working with JSON:API APIs. It supports mapping to custom model classes, fetching, advanced querying, linking and persisting.
MIT License
266 stars 109 forks source link

Skip unregistered types in included resources #104

Closed jensgrud closed 7 years ago

jensgrud commented 8 years ago

Fixes issue in https://github.com/wvteijlingen/Spine/pull/90 where unregistered types in included resources break deserialization. Unsure if this is the best place to do it.

clacladev commented 7 years ago

This PR would greatly improve the Api and first-use of this library. Can it be updated and merged?

jensgrud commented 7 years ago

Rebased and pushed. Thanks ccarnino.

clacladev commented 7 years ago

Great! @wvteijlingen what do you think about it? Can you get it merged? I think that skipping unregistered resource types make a much more solid parser. Right now if the backend guys decide to add a new resource type, the entire parsing will fail. Meaning that the production apps will stop working. Thanks to everyone involved!

wvteijlingen commented 7 years ago

You're absolutely right. This will make deserialisation much more robust. Thanks! 👍

wvteijlingen commented 7 years ago

I think something is wrong with the Travis config. The tvOS build seems to fail randomly without any apparent reason.

jensgrud commented 7 years ago

Got it, can I do anything?

clacladev commented 7 years ago

👏

wvteijlingen commented 7 years ago

@jensgrud: You could look into why this failure on Travis occurs if you'd like. But as long as iOS and macOS build fine I'm not too worried.

jensgrud commented 7 years ago

Awesome guys, thanks - saving Travis debugging for an other day ;)