Fixed rare crash because of dangling KVO pointer

wvteijlingen / Spine

A Swift library for working with JSON:API APIs. It supports mapping to custom model classes, fetching, advanced querying, linking and persisting.

MIT License

264 stars 109 forks source link

Fixed rare crash because of dangling KVO pointer #106

Closed invliD closed 7 years ago

invliD commented 7 years ago

Sometimes, during CoreAnimation animations, my app would nondeterministicly crash because of a KVO observer callback where the observer has already been deallocated. After a long debugging session I figured out that Spine's SaveOperation is the culprit. This PR fixes this issue by adding a matching removeObserver call.

invliD commented 7 years ago

@wvteijlingen: Done.

wvteijlingen commented 7 years ago

Awesome, thank you! 👍