update only dirty attributes fixed (incl. Test)

wvteijlingen / Spine

A Swift library for working with JSON:API APIs. It supports mapping to custom model classes, fetching, advanced querying, linking and persisting.

MIT License

264 stars 109 forks source link

update only dirty attributes fixed (incl. Test) #116

Closed OliverDobner-flinc closed 7 years ago

OliverDobner-flinc commented 7 years ago

I fixed the issue that dirty fields checking was not enabled on updating a resource.

OliverDobner-flinc commented 7 years ago

@wvteijlingen I implemented isDirty as computed property and fixed the nil deserialization handling. What do you think about this one?

OliverDobner-flinc commented 7 years ago

So, now I did write tests for checking updating relationships only if dirty and implemented the check.

wvteijlingen commented 7 years ago

Thanks a lot! I'll see if I can merge dirty-checking into master in the coming days. Will probably not be an easy merge, since so much changed in the meantime.

urbany commented 7 years ago

Hi @wvteijlingen any update on merging this with master? Thanks in advance!