wvu-patterns / wvu-patterns-footer-credits

WVU Pattern Library - Footer Credits Module
0 stars 0 forks source link

Add note about how to override a !default variable #2

Open adamjohnson opened 10 years ago

adamjohnson commented 10 years ago

Variables marked with !default need to be overridden before the $example: 10px !default is defined. Many people don't know this; thereby, this should be stated somewhere.

zeroedin commented 10 years ago

Again this should be done in the starter-kit not in the footer-credits module. The starter kit should document all the dependencies and their !default variables and how to override them.

dustinmazon commented 10 years ago

I just updated the ReadMe. Let me know what you think and if anything should be taken out.

adamjohnson commented 10 years ago

Should "overwrite" be "override"?

Also, I suppose if we're going to use !default, we should be sure that people are going to have a styles.scss/Sass index file like this:

// --Variables--
@import "partials/_variables"; // Variables first

// --Utilities--
@import "utilities/_media-queries";

// --Vendor--
@import "vendor/_wvu-patterns__footer-credits";

// --Partials--
@import "partials/_base";

Instead of like this:

// --Vendor--
@import "vendor/_wvu-patterns__footer-credits"; // Pattern first

// --Variables--
@import "partials/_variables";

// --Utilities--
@import "utilities/_media-queries";

// --Partials--
@import "partials/_base";

Tricky. Open to others' thoughts. I say keep !default.

zeroedin commented 10 years ago

This again will be done in the starter-kit, let me get there you hippies :P

dustinmazon commented 10 years ago

Yeah, I agree. We can just link over to the starter-kit for examples and demos.