search

wvuweb / brand-patterns

Theme for Brand Patterns
1 stars 2 forks source link

Make footer partials reference shared partials #54

Closed adamjohnson closed 9 years ago

adamjohnson commented 9 years ago

In CleanSlate, there are such a thing as shared partials:

http://cleanslatecms.wvu.edu/how-to/theme-development/partials#shared-partials

Currently, brand-patterns does not use shared footer partials. I noticed today, in every footer of a brand-patterns based theme, there's a link to http://brand.wvu.edu/web-standards . This link currently redirects to http://webstandards.wvu.edu . If you run a link check on any brand-patterns based site (like this one), it'll yell at you.

At the moment, the only way to fix this link to point to http://webstandards.wvu.edu is to manually fix the link in every single theme. :-( :-1:

So I propose we make those partials shared. They can reference the code repository in Stash. From what I can tell, @adamglenn copied those footer partials 1:1, so referencing the Code repo should be fine.

If anyone has any objections, speak now or forever hold your peace.

adamjohnson commented 9 years ago

This commit to the Code repo is related to this issue.