search

wvuweb / brand-patterns

Theme for Brand Patterns
1 stars 2 forks source link

Quicklinks SCSS #72

Closed osteffich closed 7 years ago

osteffich commented 7 years ago

I've tried to implement the Quicklinks brand pattern and come across an error.

I made sure to include the recommended "@import 'wvu-quicklinks--flex';" on the modules-dir.scss file but am still getting a result that looks like the attached.

Should another SCSS file be referenced somewhere?

image

adamglenn commented 7 years ago

What site is this happening on? Can you give me a link?

osteffich commented 7 years ago

I am still developing and found it in hammer - but I committed so you can see it here: http://ifs.sandbox.wvu.edu/home The quicklinks are right above the social media bar near the footer.

On Wed, Dec 7, 2016 at 4:14 PM, Adam Glenn notifications@github.com wrote:

What site is this happening on? Can you give me a link?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wvuweb/brand-patterns/issues/72#issuecomment-265575206, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWjG2pLLrlweVKE9f9edUKb9KRI4EFSks5rFyGbgaJpZM4LHFme .

adamglenn commented 7 years ago

You need to include the wvu-quicklinks.scss file in your layouts-dir and modules-dir files. Looks like that is not in the documentation. Will fix.

osteffich commented 7 years ago

I just added @import 'wvu-quicklinks'; to the layouts-dir file, and it adds some margin to the left and right, but doesn't add enough padding to make it look like the example. The background color is still also not there.

I'll wait till tomorrow to revisit this.

On Wed, Dec 7, 2016 at 4:32 PM, Adam Glenn notifications@github.com wrote:

You need to include the wvu-quicklinks.scss file in your layouts-dir and modules-dir files. Looks like that is not in the documentation. Will fix.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wvuweb/brand-patterns/issues/72#issuecomment-265579739, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWjGxIwefdNQhV-LNYJZnLU-5_XiOdsks5rFyXYgaJpZM4LHFme .

osteffich commented 7 years ago

Ok - also added wvu-quicklinks.scss to the modules file along with the wvu-quicklinks--flex.scss. Fixed it! Thank you.

On Wed, Dec 7, 2016 at 4:39 PM, Octavia Steffich osteffich@gmail.com wrote:

I just added @import 'wvu-quicklinks'; to the layouts-dir file, and it adds some margin to the left and right, but doesn't add enough padding to make it look like the example. The background color is still also not there.

I'll wait till tomorrow to revisit this.

On Wed, Dec 7, 2016 at 4:32 PM, Adam Glenn notifications@github.com wrote:

You need to include the wvu-quicklinks.scss file in your layouts-dir and modules-dir files. Looks like that is not in the documentation. Will fix.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wvuweb/brand-patterns/issues/72#issuecomment-265579739, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWjGxIwefdNQhV-LNYJZnLU-5_XiOdsks5rFyXYgaJpZM4LHFme .

adamglenn commented 7 years ago

Documentation has been updated. Not sure how that went unnoticed for so long.