search

wvuweb / cleanslate-cms

A place to file issues and view releases for CleanSlate CMS. http://cleanslatecms.wvu.edu
6 stars 0 forks source link

r:breadcrumbs tag should output link attributes #252

Closed adamjohnson closed 5 years ago

adamjohnson commented 5 years ago

Steps to reproduce the issue

  1. Visit the Downtown Campus Library or Bennett Tower Gallery - Housing pages. a) NOTE: Both of these pages have the requisite link attributes specified via Page Properties (Libraries Pages and Housing Pages in CleanSlate).
  2. Run the Siteimprove Accessibility Chrome Extension.

Results

It returns the "Link text used for multiple different destinations" WCAG A error.

Expected results

The <r:breadcrumbs /> tag should output the link attributes specified in Page Properties > Link Attributes.

Link Attributes Modal

include_link_ids should default to false for the <r:breadcrumbs /> tag.

cc/ @jetapia @ WVU Libraries.

adamjohnson commented 5 years ago

Relevant commits:

wvuweb/cleanslate@589e7247c38868c0b4e03f2d423d7db0e24b0684

wvuweb/cleanslate@cc3ae3126743f59df12e1027cb408f08015c5fd3

wvuweb/cleanslate@6b9d3d7e4319c18e150d49281677d2cd82986209

nreckart commented 5 years ago

The custom link attributes should now be applied to breadcrumb links as they are for the other menu tags. include_link_ids defaults to false, so templates will need to be updated in order for custom id attributes to be applied to the breadcrumb links.

Example:

<r:breadcrumbs ul_id="main-breadcrumbs" ul_class="breadcrumb" include_link_ids="true" />

adamjohnson commented 5 years ago

Youdaman! 💯

I updated the docs for breadcrumbs on CleanSlateCMS.