search

wvuweb / cleanslate-cms

A place to file issues and view releases for CleanSlate CMS. http://cleanslatecms.wvu.edu
6 stars 0 forks source link

r:breadcrumb should have an attribute to apply classes to links #253

Closed adamglenn closed 3 years ago

adamglenn commented 5 years ago

I want to be able to add utility classes to links in breadcrumbs to make it easier to use with new design system. so something like <r:breadcrumbs link_class="text-white" />.

adamglenn commented 5 years ago

Also, I assume this would allow me to pass in a variable, so <r:breadcrumbs link_class="{$breadcrumbLinkColor}" />.

nreckart commented 5 years ago

Would the class be applied to the <a> or the <li>?

adamglenn commented 5 years ago

The <a>.

nreckart commented 5 years ago

link_class is now a valid option for <r:breadcrumbs>

Example: <r:breadcrumbs ul_id="fancycrumbs" ul_class="breadcrumb" " link_class="super-fancy" />

adamjohnson commented 5 years ago

I've added link_class to the docs for r:breadcrumbs on CleanSlateCMS.

AG: When you confirm this is working, kindly close this issue.

adamglenn commented 5 years ago

This actually doesn't work. What it does is apply an attribute of link_class to the breadcrumb html i.e. <a link_class="whatever-my-class-is">. Should output <a class="whatever-my-class-is">.

nreckart commented 5 years ago

@adamglenn This should be fixed. Can you verify and close?