search

wvuweb / hammer

A tool for CleanSlate theme development
https://cleanslate.wvu.edu
4 stars 2 forks source link

Shared themes with different name vs repo names are busted #41

Closed adamjohnson closed 8 years ago

adamjohnson commented 8 years ago

Steps to reproduce the issue

  1. Clone the Adventure WV Repo and the Adventure WV Orientation repo from Stash.
  2. Create a partial named _hello-world.html in cleanslate_themes/student-life-adventure-wv/views/shared.
  3. Add an <h1> inside the file with Hello World as it's content.
  4. Start hammer.
  5. Open the Adventure WV Orientation theme in your text editor.
  6. Open frontpage.html. Paste <r:partial name="shared/hello-world" theme="Student Life: Adventure WV" />.
  7. Open the Mock Data file and add this under the shared themes key: 
  "Student Life: Adventure WV":
    "shared/hello-world": "student-life-adventure-wv"

View http://localhost:2000/student-life-adventure-wv-orientation/views/frontpage.html in your browser.

Results

Hammer cannot find the shared partial and throws an error.

Expected results

Hammer should find the shared partial and print its contents.

I suspect this error stems from having fancy characters in the theme name. Eg: Student Life: Adventure WV.

adamjohnson commented 8 years ago

22 is related to this.

zeroedin commented 8 years ago

Link in commit message didn't work correctly should link to: https://github.com/wvuweb/hammer/commit/d78a471cd6ed111dfc7e17e6e2eb015b22fac781