wvuweb / hammer

A tool for CleanSlate theme development
https://cleanslate.wvu.edu
4 stars 2 forks source link

Allow users to configure the URL for "Home" in breadcrumbs #55

Closed adamjohnson closed 5 years ago

adamjohnson commented 5 years ago

Link text used for multiple different destinations error

We see this accessibility error in local development on every single site we make. The "Home" href in the main nav is different from the "Home" href in the breadcrumbs. For example, one is:

I would like to be able to customize the content of the href attribute in the r:breadcrumbs tag. I think this will help CleanSlate designers when remediating their sites. People like to be able to achieve a "clean slate" in local development (see what I did there?).

Relevant:

https://github.com/wvuweb/hammer/blob/master/hammer/services/tags/basic.rb#L487

zeroedin commented 5 years ago

I believe you can already do this by adding a breadcrumbs data point in mock_data.yml

breadcrumbs: |
  <ul class="wvu-breadcrumbs__crumbs">
    <li><a href="/">Home</a></li>
    <li class="active">Page</li>
  </ul>

By doing this however you lose the interpolation of attribute options from the radius tag.