wvuweb / hammer

A tool for CleanSlate theme development
https://cleanslate.wvu.edu
4 stars 2 forks source link

Shared themes should default to the code repository #7

Closed adamjohnson closed 10 years ago

adamjohnson commented 10 years ago

If a user has the shared masthead or footer being served from the code repository, hammer shouldn't have to be configured to point to the code repo via the mock_data.yml file. In other words, this:

shared_themes:
  layouts__masthead--v1: "code"
  layouts__footer__contact--v1: "code"
  layouts__footer__credits--v1: "code"
  layouts__footer__icons--v1: "code"
  layouts__browser-update-org--v1: "code"

...shouldn't be required. Hammer should assume these shared themes will be served from the code repo.

Now, let's say Eberly has a shared partial or something, once someone writes out shared_themes in the mock data file, that's when this stuff must be configured.

zeroedin commented 10 years ago

It is my opinion that the shared theme is not required by every theme. So I do not see this as something you are overriding, but adding in addition to your theme. You can shared a template from any "repo", and that does not by default to the "code" repo so hammer should also not default to "code".