search

ww-tech / roxie

Lightweight Android library for building reactive apps.
Apache License 2.0
482 stars 36 forks source link

Added coroutines version of roxie #20

Open dragossusi opened 3 years ago

dragossusi commented 3 years ago

Updated the code to create rxjava2 version and coroutines version

Both can be used in the same project(check sample)

I didn't check unit tests, but the sample works.

May need maven-publish configuration for publishing the new artifacts.

michaelcarrano commented 3 years ago

Thank you for this contribution, will need to spend some time reviewing it.

Hopefully, I will have some time later this week to start to look at the changes. I was on PTO last week when this was submitted.

michaelcarrano commented 3 years ago

Just to update those following this PR - @dragossusi has joined the WW team so we'll be collaborating/discussing this internally.

dragossusi commented 2 years ago

We should migrate from ConflatedBroadcastChannel to SharedFlow