ww3877989 / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

compile error #528

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.centos 4.3
2.r1166.
3.

src/common/dwarf_cu_to_module.cc: In member function `virtual void 
google_breakpad::DwarfCUToModule::GenericDIEHandler::ProcessAttributeReference(d
warf2reader::DwarfAttribute, dwarf2reader::DwarfForm, uint64)':
src/common/dwarf_cu_to_module.cc:163: error: `bool 
google_breakpad::DwarfCUToModule::FileContext::IsUnhandledInterCUReference(uint6
4, uint64) const' is private
src/common/dwarf_cu_to_module.cc:311: error: within this context
./src/common/dwarf_cu_to_module.h:121: error: 
`google_breakpad::scoped_ptr<google_breakpad::DwarfCUToModule::FilePrivate> 
google_breakpad::DwarfCUToModule::FileContext::file_private_' is private
src/common/dwarf_cu_to_module.cc:321: error: within this context
src/common/dwarf_cu_to_module.cc: In member function `std::string 
google_breakpad::DwarfCUToModule::GenericDIEHandler::AddStringToPool(const 
std::string&)':
./src/common/dwarf_cu_to_module.h:121: error: 
`google_breakpad::scoped_ptr<google_breakpad::DwarfCUToModule::FilePrivate> 
google_breakpad::DwarfCUToModule::FileContext::file_private_' is private
src/common/dwarf_cu_to_module.cc:341: error: within this context
src/common/dwarf_cu_to_module.cc: In member function `std::string 
google_breakpad::DwarfCUToModule::GenericDIEHandler::ComputeQualifiedName()':
./src/common/dwarf_cu_to_module.h:121: error: 
`google_breakpad::scoped_ptr<google_breakpad::DwarfCUToModule::FilePrivate> 
google_breakpad::DwarfCUToModule::FileContext::file_private_' is private
src/common/dwarf_cu_to_module.cc:410: error: within this context
src/common/dwarf_cu_to_module.cc: In member function `virtual void 
google_breakpad::DwarfCUToModule::FuncHandler::ProcessAttributeReference(dwarf2r
eader::DwarfAttribute, dwarf2reader::DwarfForm, uint64)':
./src/common/dwarf_cu_to_module.h:121: error: 
`google_breakpad::scoped_ptr<google_breakpad::DwarfCUToModule::FilePrivate> 
google_breakpad::DwarfCUToModule::FileContext::file_private_' is private
src/common/dwarf_cu_to_module.cc:497: error: within this context
src/common/dwarf_cu_to_module.cc: In member function `virtual void 
google_breakpad::DwarfCUToModule::FuncHandler::Finish()':
./src/common/dwarf_cu_to_module.h:121: error: 
`google_breakpad::scoped_ptr<google_breakpad::DwarfCUToModule::FilePrivate> 
google_breakpad::DwarfCUToModule::FileContext::file_private_' is private
src/common/dwarf_cu_to_module.cc:553: error: within this context
make: *** [src/common/dwarf_cu_to_module.o] Error 1

please help fix it.
thanks.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by issac.xw...@gmail.com on 27 Apr 2013 at 7:20

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
revision 1163 introduces these errors.

Original comment by issac.xw...@gmail.com on 27 Apr 2013 at 10:11

GoogleCodeExporter commented 9 years ago
Sure, I'll take a look. I wish you would stop using an 8 year old Linux distro. 
:-P

Original comment by thestig@chromium.org on 29 Apr 2013 at 7:35

GoogleCodeExporter commented 9 years ago
What compiler are you using? It builds fine for me on Centos 4.9 with g++ 4.1.2.

Original comment by thestig@chromium.org on 29 Apr 2013 at 8:18

GoogleCodeExporter commented 9 years ago
hi thestig:
  my compiler is gcc 3.4.5

  I wish we could use a newer version of linux, but it is not the decision I can make.
  our customers depend on that old os and compiler.

  thank you for your respones.

Original comment by issac.xw...@gmail.com on 30 Apr 2013 at 10:07

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
gcc 3.4.5(?!) I don't know that we're going to jump through hoops to support a 
compiler that old.

Original comment by ted.mielczarek on 30 Apr 2013 at 11:40

GoogleCodeExporter commented 9 years ago
hi thestig:

  Could you have a look at issue #527?
  I have provided a patch for it.
  It should work. :)

Original comment by issac.xw...@gmail.com on 30 Apr 2013 at 3:57

GoogleCodeExporter commented 9 years ago
You already cannot build the code out of the box with such an older compiler. 
You can apply the attached patch to solve this bug, but we are probably not 
going to commit it.

Original comment by thestig@chromium.org on 30 Apr 2013 at 8:20

Attachments:

GoogleCodeExporter commented 9 years ago
why not ?

Isn't it better to make it backward-compatible?

lots of source code out there depend on the old compiler and old os...

Original comment by issac.xw...@gmail.com on 1 May 2013 at 7:16

GoogleCodeExporter commented 9 years ago
Because RHEL 4's lifecycle ended over a year ago. Again, you can't even run: 
"./configure; make" out of the box...

Original comment by thestig@chromium.org on 1 May 2013 at 7:12

GoogleCodeExporter commented 9 years ago
yes, I can. I do have some troubles in compiling, but "./configure" works 
well...
I just have to change makefile a little bit to make it work...

Original comment by issac.xw...@gmail.com on 2 May 2013 at 2:03