search

wwarthen / RomWBW

System Software for Z80/Z180/Z280 Computers
GNU Affero General Public License v3.0
332 stars 98 forks source link

Add port option to XM's send mode #354

Closed oholiab closed 1 year ago

oholiab commented 1 year ago

This change makes so that you can send files from XM on the specified serial port matching the receive functionality. This is already in the usage text for XM but the code was never actually plumbed in for the send option so the only valid additional send option was 'K'.

I've tested this build with:

xm s1k some.txt
xm sk1 some.txt
xm s1 some.txt

All work just fine, sending on the correct port and showing e.g. HBIOS FastPath on COM1 and (1k protocol selected) where appropriate.

This is pretty much my first foray into using asm in anger so let me know if anything needs fixing up, especially if you have feedback with regards to best practices and code style.

wwarthen commented 1 year ago

Can't believe I missed that and that it has been this long before it was found.

Thank you for this contribution Matt. The code looks fine. I am going to merge your changes now, but will not produce a new Development Snapshot until I can test this weekend.

Thanks!

Wayne

wwarthen commented 1 year ago

I was able to confirm this is working and have released SnapShot Version v3.3.0-dev.42 incorporating your fix.

Thanks @oholiab,

Wayne

oholiab commented 1 year ago

Amazing, thanks so much!