search

wwiecek / baggr

R package for Bayesian meta-analysis models, using Stan
GNU General Public License v3.0
46 stars 12 forks source link

Issues #151 and #148 resolved #155

Closed dannytoomey closed 1 year ago

dannytoomey commented 1 year ago

Hi Witold,

Here's a pull request that resolves issues #151 and #148.

I updated my forked repository's code to the latest commit on the devel branch, but GitHub indicates it can't automatically merge. I'm not sure why. Let me know if there's anything else I should change!

Best regards,

Danny Toomey

dannytoomey commented 1 year ago

Found a small error after rebasing, currently fixing and will add a new commit with fix.

dannytoomey commented 1 year ago

Sorry for the force push here. I was messing with codecov and accidentally pushed a commit on this branch I meant to make on another one, so I reset this branch to the correct commit.

wwiecek commented 1 year ago

@dannytoomey same problem as in other PR, you created a large .so file. Can you delete this PR and start a fresh one to devel where you don't commit .so? I don't want to have that file anywhere in the history because it increases size of the repo many times

dannytoomey commented 1 year ago

Removed .so file and updated .gitignore

dannytoomey commented 1 year ago

Misread your initial comment, I will close this PR and open a new one without any commits including the .so files