search

wwiecek / baggr

R package for Bayesian meta-analysis models, using Stan
GNU General Public License v3.0
46 stars 12 forks source link

Change bg$effects to bg$label and update throughout #164

Closed dannytoomey closed 1 year ago

dannytoomey commented 1 year ago

Hi Witold,

Here's a commit that resolves issue #150. I changed the effect argument in baggr to label and changed all instances of functions using bg$effects to bg$label. I kept effect as a passable argument to baggr for compatibility and added a message requesting use of the new label argument. Let me know how this looks!

Best regards,

Danny Toomey

wwiecek commented 1 year ago

Thanks! Will review this when merging your other PRs/fixes and let you know if any problems

wwiecek commented 1 year ago

Kill this commit and make a fresh one (1) making the same changes but without .so file (2) or purge .so file from history, but this can be more tricky (wouldn't recommend) (3) or cherry pick changes to the relevant files only (like (1) but can be done via git)

dannytoomey commented 1 year ago

Removed .so files and updated .gitignore