Closed dannytoomey closed 8 months ago
Don't merge yet, this does not pass build checks.
Update - Disregard! My R and RStan were out of date. I updated and this works fine now. This is probably the case for the other PRs as well, as I tested them locally before opening the new PR and then retested later with updated packages, at which point they stopped working and I made these comments. I will continue retesting and update the comments once double checked.
Done on devel
Hi Witold,
Apologies for adding the .so and Makeovers files to the PRs so far! I added
src/Makevars
,src/Makevars.win
, andsrc/*.so
to.gitignore
so this doesn't happen again. Here's a commit that resolves issue #115 with only the intended files changes.Best regards,
Danny Toomey