wwivbbs / wwiv

WWIV BBS Software v5
http://www.wwivbbs.org
Other
186 stars 71 forks source link

WWIV is adding trailing whitespace to recipient names in FTN echomail messages. #1607

Open wwiv opened 1 year ago

wwiv commented 1 year ago

ust a head's up: WWIV is adding trailing whitespace to recipient names in FTN echomail messages. Example: Opening fsx_gen

index record 5031 Sender Utopian Galt To Digital Man Subject Re: New Mazda X-FTN-AREA FSX_GEN X-FTN-TID WWIV NET5.9.0.3691 X-FTN-CHRS CP437 2 X-FTN-MSGID 21:4/108 646F6CD2 X-FTN-REPLY 101965.fsx_gen@21:1/183 28d53680 X-FTN-PID WWIV 5.9.0.3691 ... hdr field[01] type 30h, length 12, data: 44 69 67 69 74 61 6C 20 4D 61 6E 20

That 0x20 on the end of the recipient name (SMB field type 30h) is an ASCII space.

wwiv commented 1 year ago
U:\bbs>xxd net\fsxnet\out\02181511.pkt
00000000: 7300 0100 7b00 0500 0200 1200 0f00 0b00  s...{...........
00000010: 4083 0200 0200 0100 ff00 0000 0000 0000  @...............
00000020: 0000 1500 1500 0000 0001 1d35 0100 1500  ...........5....
00000030: 1500 0000 0000 0000 0000 0200 7300 0100  ............s...
00000040: 0200 0100 0001 0000 3032 204a 756e 2032  ........02 Jun 2
00000050: 3320 2031 383a 3135 3a30 3900 4a61 686d  3  18:15:09.Jahm
00000060: 6173 0052 7573 6866 616e 0052 653a 2043  as.Rushfan.Re: C
00000070: 6872 6973 746d 6173 0041 5245 413a 4653  hristmas.AREA:FS
00000080: 585f 4745 4e0d 0154 4944 3a20 5757 4956  X_GEN..TID: WWIV
00000090: 204e 4554 352e 392e 302e 6465 7665 6c6f   NET5.9.0.develo
000000a0: 706d 656e 740d 0143 4852 533a 2043 5034  pment..CHRS: CP4
000000b0: 3337 2032 0d01 545a 5554 433a 202d 3037  37 2..TZUTC: -07
000000c0: 3030 0d01 4d53 4749 443a 2032 313a 322f  00..MSGID: 21:2/
000000d0: 3131 3520 3634 3741 3934 3145 0d01 5245  115 647A941E..RE
000000e0: 504c 593a 2032 313a 312f 3133 3320 3031  PLY: 21:1/133 01
000000f0: 3137 3761 6361 0d42 593a 206a 6168 6d61  177aca.BY: jahma
00000100: 7328 3231 3a31 2f31 3333 290d 0150 4944  s(21:1/133)..PID
00000110: 3a20 5757 4956 2035 2e39 2e30 2e64 6576  : WWIV 5.9.0.dev
00000120: 656c 6f70 6d65 6e74 0d0d 6a3e 2057 656c  elopment..j> Wel
00000130: 6c20 7765 2077 6572 6520 6578 7065 6374  l we were expect
00000140: 696e 6720 7175 6974 6520 7468 6520 7374  ing quite the st
00000150: 6f72 6d20 6865 7265 206f 6e20 4361 7065  orm here on Cape
00000160: 2043 6f64 2e20 4974 2077 6173 206d 7920   Cod. It was my
00000170: 7475 726e 0d0d 0d0d 2d2d 2d20 5757 4956  turn....--- WWIV
00000180: 2035 2e39 2e30 2e64 6576 656c 6f70 6d65   5.9.0.developme
00000190: 6e74 5b57 696e 646f 7773 5d0d 202a 204f  nt[Windows]. * O
000001a0: 7269 6769 6e3a 204d 7920 5757 4956 2042  rigin: My WWIV B
000001b0: 4253 2028 3231 3a32 2f31 3135 290d 5345  BS (21:2/115).SE
000001c0: 454e 2d42 593a 2032 2f31 3135 0d0d 0000  EN-BY: 2/115....
000001d0: 00

Looking at an outgoing packet I just created, bytes at position 62 is the end of the TO field and doesn't have a space. Any thoughts where else this could be coming from along the way?

wwiv commented 1 year ago

02181511.zip is the packet