wwivbbs / wwiv

WWIV BBS Software v5
http://www.wwivbbs.org
Other
186 stars 71 forks source link

FSED color matching & Delete issues #1622

Open the-godfather-007 opened 9 months ago

the-godfather-007 commented 9 months ago

FSED's top divider / window lines do not match once system colors have been modified to the SysOps desired appearance. See preview. Screenshot from 2024-02-04 22-26-25

Also, when moving arrows to edit text the delete key is backspacing (deleting text to the left of the cursor) from the point of cursor position as opposed to deleting the text to the right of the cursor. I've only tested this in Netrunner.

ericpareja commented 2 months ago

Can you attach the relevant WWIV.INI or config for system colors? Thanks! :)

the-godfather-007 commented 1 month ago

The system colors in wwiv.ini should not matter, the lower divider line should match whatever system colors we select as the default for all users who login as "new" to the sytem, should it not?

ericpareja commented 1 month ago

On Sat, Sep 28, 2024 at 11:24:04AM -0700, The Godfather wrote:

The system colors in wwiv.ini should not matter, the lower divider line should match whatever system colors we select as the default for all users who login as "new" to the sytem, should it not?

They shouln't. However, I want to be able to replicate the conditions to reproduce the bug on my system.

ericpareja commented 1 month ago

The system colors in wwiv.ini should not matter, the lower divider line should match whatever system colors we select as the default for all users who login as "new" to the sytem, should it not?

Hi again... they shouldn't matter, but to help me find what exact code lines aren't working properly, I need something to help identify what conditions make the bug visible. Otherwise, I have to try changing a lot of WWIV.INI settings. I have identified the block of code where I should be looking, but need your input to be able to track which specific lines aren't working properly. For reference, I've narrowed the search for the bug to common/full_screen.cpp in the FullScreenView::DrawBottomBar() function.

the-godfather-007 commented 3 weeks ago
                           COLOR OPTIONS

;============================================================================= ; ; NOTE: Although the BBS is capable of using over 90 color combinations, ; only the first ten may be set here. The remaining colors are set from ; inside the BBS. ; ; Colors are selected numerically. To determine the value for a color, use the ; following chart: ; ; 0 = Black 8 = Dark Gray ; 1 = Blue 9 = Light Blue ; 2 = Green 10 = Light Green ; 3 = Cyan 11 = Light Cyan ; 4 = Red 12 = Light Red ; 5 = Magenta 13 = Light Magenta ; 6 = Brown 14 = Yellow ; 7 = Light Gray 15 = White ; ; Now, to calculate a color, you take the value for the background color and ; multiply by 16, then add it to the foreground color you wish. This will ; provide the value you should use for that color combination. Note that ; color values greater than 127 will result in blinking. In other words, ; you should probably restrict background colors to colors 0-7 above. ; ; An example: if you want to find the value for, say, bright yellow on ; magenta, it would be (516) + 14. This equates to (magenta 16) + white. ; ; ---------------------------------------------------------------------------- NUCOLOR[0] = 7 NUCOLOR[1] = 15 NUCOLOR[2] = 7 NUCOLOR[3] = 7 NUCOLOR[4] = 59 NUCOLOR[5] = 11 NUCOLOR[6] = 10 NUCOLOR[7] = 7 NUCOLOR[8] = 5 NUCOLOR[9] = 7 NUCOLORBW[0] = 3 NUCOLORBW[1] = 15 NUCOLORBW[2] = 15 NUCOLORBW[3] = 15 NUCOLORBW[4] = 112 NUCOLORBW[5] = 15 NUCOLORBW[6] = 15 NUCOLORBW[7] = 7 NUCOLORBW[8] = 7 NUCOLORBW[9] = 7 ; ; System Colors ; TOPCOLOR = 27 ; for topscreen info F1COLOR = 9 ; for F1 user editor EDITLINECOLOR = 31 ; current field in F1 CHATSELCOLOR = 11 ; for selecting sysop MSG_COLOR = 2 ; for color msgs ;