search

wwmm / easyeffects

Limiter, compressor, convolver, equalizer and auto volume and many other plugins for PipeWire applications
GNU General Public License v3.0
6.62k stars 270 forks source link

Desktop icon has a black background #1597

Closed Knebergish closed 2 years ago

Knebergish commented 2 years ago

EasyEffects Version

6.2.6

What package are you using?

Flatpak (Flathub)

Distribution

Fedora 36 Kinoite

Describe the bug

After the recent update of EasyEffects in Flatpak, the application icon began to be displayed with a black background instead of transparency. When viewing icons in Dolphin, this problem is observed only with the EasyEffects icon. BlackBackIco

Expected Behavior

The icon has a transparent background instead of a black fill.

Debug Log

No response

Additional Information

No response

Digitalone1 commented 2 years ago

@bertob can you fix it?

wwmm commented 2 years ago

When viewing icons in Dolphin, this problem is observed only with the EasyEffects icon.

Only in Dolphin or anywhere in KDE? Considering QT has problems with SVG files I imagine that anything using QT is showing the new icon this way.

Knebergish commented 2 years ago

On the desktop and taskbar too. Desktop Taskbar

Digitalone1 commented 2 years ago

Don't know the cause of this, but we had also the same issue with the previous icon and a commit was made to fix it. Am I right?

Knebergish commented 2 years ago

For me the problem is reproduced with this picture - in Dolphin and Gwenview it is displayed with a black background.

wwmm commented 2 years ago

Am I right?

Yes. The explanation about the fix is in this comment https://github.com/wwmm/easyeffects/issues/867#issuecomment-1056077158. According to the person that found the it:

" The issue you're seeing here is that in KDE we use the Qt SVG renderer, which supports only a subset of the SVG standard. We are trying to change this, but there is no ETA currently.

Most icons work fine, but among icons that are broken, the most common problem is that they use masking or clipping paths, both of which Qt does not support.

A workaround is to use ordinary paths instead of relying on clip paths. It's not always as clean of an approach, but the result avoids the issue in Qt applications. "

How to do the same thin in the new icon I do not know.

Knebergish commented 2 years ago

I found a similar old problem in another application, but I have too little experience with SVG to understand how to edit the image correctly.

wwmm commented 2 years ago

but I have too little experience with SVG to understand how to edit the image correctly.

Same thing with me. I will wait for the help of someone that actually knows this kind of stuff. Ideally QT should have better support for SVG. But considering how many years have passed since we faced this issue with QT for the first time and it is still here I have lost hope it is going to be fixed on its side...

Digitalone1 commented 2 years ago

Someone can try with svgcleaner or scour to minify the svg code and test it on QT.

Knebergish commented 2 years ago

Seems like this version of icon works well. com github wwmm easyeffects2 In all places now icon shows correctly: Dolphin2 Desktop2 Taskbar2 In image I removed all "mask" and "clipPath" sections and added "fill-opacity" to "g" sections.

Digitalone1 commented 2 years ago

@Knebergish made a pull request to add the version you suggested.

Knebergish commented 2 years ago

Thanks @Digitalone1!

wwmm commented 2 years ago

I think we can close this issue.