Improve Gate layout

[Digitalone1]

@wwmm @LebedevRI What do you think?

Curve and Hysteresis spinbuttons grouped with linked Adw style. The labels above enclosed in an homogeneous box. I like it more.

If it's good for you, I'll make the MR.

[wwmm]

It seems good to me. But are you sure that the linked style class is doing something? If I remember well it does nothing when the GtkBox has a space between children set.

[Digitalone1]

Not 100% sure, there's no spacing set inside the box. Maybe you can take a look during the review.

[LebedevRI]

• i like more closely located the threshold and zone spinbuttons, that is already what is being done in master, just not as aggressively
• i think, grouping the spinbuttons+label might be good
• i don't like checkbox. i did originally use it but then intentionally switched away to the button
• i don't see why the new label location is better?

[LebedevRI]

• i don't see why the new label location is better?

Or more concretely, i have a big problem with UI's that are made to look shiny cool, at the cost of understandability/usability. I don't claim that the current UI is ideal:

but i think it's pretty obvious that the Curve label does not apply to the Release spinbutton, and Hysteresis label does not apply to the Reduction, because the spinbuttons are visually different. That is not as obvious with

although it's mitigated somewhat by the closeness of the spinbuttons.

[Digitalone1]

What I don't like in the master layout is the different height of the spinbuttons. At least we use the same height in UI with vertical spinbuttons

The button for Hysteresis could be good, but I like more the checkbutton because it's more aligned with the curve label.

It seems obvious to me where Curve/Hysteresis applies. So you like only the linked spinbuttons?

[LebedevRI]

So you like only the linked spinbuttons?

I do like linked/grouped spinbuttons+label. I'm not sure about the rest.

Now that i actually look, apparently i lost "Gating" indicator.

[Digitalone1]

This should be better. Previously I forgot the margins around the spinbuttons.

Anyway I still don't like the different height of spinbuttons. Having them aligned on the last row is better in my opinion.

[wwmm]

This week I had tons of things to do at my work. Only now I could stop to look at this.

I am ok with both solutions. When the buttons have the same height it is still possible to see that there are different sections. But it is definitely easier to notice them with different buttons size. On the other hand different button sizes have the problem that the GtkEntry the spinbutton uses to show/edit the number is now unnecessarily large in the vertical. What is a little ugly and super easy to notice.

Maybe if we put the buttons and the labes of the curve and hysteresis sections inside a Gtkbox with the card css class we can have both things without the need to change the button size.

[wwmm]

Or maybe just creating two more pairs of button linked by the linked css class. Attack and Release are usually something we think at the same time. So they could be together. And for consistency the same could be done for the Reduction and Makeup buttons. This way it would be easy to see that there are 4 different blocks without having to force different button heights.

[wwmm]

This is how it looks like if we group the other buttons It seems enough to me to make it easier to see that curve and hysteresis are a block. And we also have the benefit that the gate window feels more compact in the horizontal direction. What do you think?

[Digitalone1]

It's okay to me. In the future we can also make dry and wet spinbuttons with link class.