Closed markonius closed 2 years ago
sebnyberg
commented
2 years ago I'm experiencing the same issue on the most recent version.
After rolling back to 6.2.6, things work as expected.
flatpak remote-info --log flathub com.github.wwmm.easyeffects
sudo flatpak update --commit <commit> com.github.wwmm.easyeffectsNothing suspicious in the logs on my end either.
vchernin
commented
2 years ago Can you confirm there is no existing instance of EasyEffects beforehand, in gnome monitor or otherwise? If so flatpak run com.github.wwmm.easyeffects -q will kill the existing instance.
I certainly did not see this when I tested the build on Fedora 36 Wayland, so I’m not sure how this is possible to break like this.
markonius
commented
2 years ago I've confirmed there is no prior instance running.
markonius
commented
2 years ago Hmmm, running flatpak run com.github.wwmm.easyeffects -q creates a new instance of EasyEffects (visible in monitor), which times out, then exits.
╰─> flatpak run com.github.wwmm.easyeffects -q
You have PipeWire 0.3.48 installed
This is newer or the same as PipeWire 0.3.41 required to run EasyEffects
Failed to register: Timeout was reachedRunning flatpak run com.github.wwmm.easyeffects -q when no other instance is running just hangs:
╰─> flatpak run com.github.wwmm.easyeffects -q
You have PipeWire 0.3.48 installed
This is newer or the same as PipeWire 0.3.41 required to run EasyEffectscreates a new instance of EasyEffects
I think it is correct that the second instance times out and is unable to start, the other EasyEffects instance should have already registered itself on D-bus. The question is why with no pre-existing instances nothing happens. Can you try with GTK_DEBUG=all?
markonius
commented
2 years ago 
wwmm
commented
2 years ago pipe_manager.cpp:1280 found metadata: settings
You should also have a default metadata. Without it EasyEffects can not get information about the default devices. Usually when the default metadata is not available the reason is that the package pipewire-pulse is not installed. I am not sure the lack of this metadata should be causing our window to not be shown. But without being able to get information about your hardware EasyEffects is useless. So the first thing to do is installing what is missing in your PipeWire installation.
markonius
commented
2 years ago OK I went through the steps outlined here: https://ubuntuhandbook.org/index.php/2022/04/pipewire-replace-pulseaudio-ubuntu-2204/
╰─> pactl info
Server String: /run/user/1000/pulse/native
Library Protocol Version: 35
Server Protocol Version: 35
Is Local: yes
Client Index: 123
Tile Size: 65472
User Name: myname
Host Name: myhostname
Server Name: PulseAudio (on PipeWire 0.3.48)
Server Version: 15.0.0
Default Sample Specification: float32le 2ch 48000Hz
Default Channel Map: front-left,front-right
Default Sink: bluez_output.40_ED_98_18_E5_CE.a2dp-sink
Default Source: alsa_input.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp_6__source
Cookie: 68ce:d20fSo even with the default metadata available there is still no window... Strange...
wwmm
commented
2 years ago Maybe it is time to see if other gtk4 apps installed through flatpak are working.
markonius
commented
2 years ago OK I've tried https://flathub.org/apps/details/com.raggesilver.BlackBox https://flathub.org/apps/details/codes.loers.Karlender
They work no problem.
EasyEffects seems to work in the background, the sinks are created and streams appear in logs:
(easyeffects:2): easyeffects-DEBUG: 17:02:49.212: pipe_manager.cpp:212 Stream/Output/Audio 86 Firefox has been removed
(easyeffects:2): easyeffects-DEBUG: 17:02:49.307: pipe_manager.cpp:1135 Stream/Output/Audio 86 Firefox with serial 143 has been added
(easyeffects:2): easyeffects-DEBUG: 17:02:49.312: pipe_manager.cpp:1175 Firefox port 89 is connected to bluez_output.40_ED_98_18_E5_CE.a2dp-sink port 80
(easyeffects:2): easyeffects-DEBUG: 17:02:49.312: pipe_manager.cpp:1175 Firefox port 91 is connected to bluez_output.40_ED_98_18_E5_CE.a2dp-sink port 82
(easyeffects:2): easyeffects-DEBUG: 17:04:53.317: pipe_manager.cpp:212 Stream/Output/Audio 86 Firefox has been removedbut there's no window.
wwmm
commented
2 years ago pipe_manager.cpp:1496 easyeffects_source node successfully retrieved with id 107 and serial 127
After this line there should be something like this
plugin_base.cpp:285 soe: output_level successfully connected to PipeWire graph
plugin_base.cpp:285 soe: spectrum successfully connected to PipeWire graphEven if no plugin has been added by the user in our plugins list. When we load the filters we make the main thread wait for the plugin to have a valid id number. I think that what may be going on is that for some reason PipeWire is not properly creating our filters in your system. And as a result EasyEffects is waiting forever for a valid id number and the main thread gets stuck. What does not allow it to get to the point where the window should be loaded.
What is the output of pw-cli list-objects Node when EE process is stuck in that last line?
wwmm
commented
2 years ago pipe_manager.cpp:1366 core version: 0.3.48
Humm... At this moment I have PipeWire 0.3.56 here on Arch Linux. Considering how fast PipeWire is evolving you have a very old version. Maybe we are doing things nowadays in a way that isn't compatible with this older version anymore.
wwmm
commented
2 years ago Maybe we are doing things nowadays in a way that isn't compatible with this older version anymore.
But 0.3.48 has only 4 months. PipeWire can't have changed so much in this time. Something else must be going on.
markonius
commented
2 years ago pipe_manager.cpp:1496 easyeffects_source node successfully retrieved with id 107 and serial 127
Just to be clear, after this, if I close/open YT videos, there are more lines logged. I assume that's in a different thread then.
(easyeffects:2): easyeffects-DEBUG: 17:50:22.726: pipe_manager.cpp:1398 compiled with PipeWire: 0.3.41
(easyeffects:2): easyeffects-DEBUG: 17:50:22.726: pipe_manager.cpp:1399 linked to PipeWire: 0.3.41
(easyeffects:2): easyeffects-DEBUG: 17:50:22.727: pipe_manager.cpp:1366 core version: 0.3.48
(easyeffects:2): easyeffects-DEBUG: 17:50:22.727: pipe_manager.cpp:1367 core name: pipewire-0
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1280 found metadata: settings
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1280 found metadata: default
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1280 found metadata: route-settings
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1135 Audio/Sink 53 alsa_output.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp_5__sink with serial 54 has been added
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1135 Audio/Sink 54 alsa_output.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp_4__sink with serial 55 has been added
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1135 Audio/Sink 55 alsa_output.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp_3__sink with serial 56 has been added
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1135 Audio/Sink 56 alsa_output.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp__sink with serial 57 has been added
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1135 Audio/Source 57 alsa_input.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp__source with serial 58 has been added
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1135 Audio/Source 58 alsa_input.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp_6__source with serial 59 has been added
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1135 Audio/Sink 79 bluez_output.40_ED_98_18_E5_CE.a2dp-sink with serial 86 has been added
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1135 Stream/Output/Audio 108 Firefox with serial 247 has been added
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1175 Firefox port 110 is connected to bluez_output.40_ED_98_18_E5_CE.a2dp-sink port 80
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1175 Firefox port 112 is connected to bluez_output.40_ED_98_18_E5_CE.a2dp-sink port 82
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1135 Audio/Sink 122 easyeffects_sink with serial 255 has been added
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:1135 Audio/Source/Virtual 114 easyeffects_source with serial 256 has been added
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:881 new metadata property: 0, default.audio.sink, Spa:String:JSON, {"name":"bluez_output.40_ED_98_18_E5_CE.a2dp-sink"}
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:881 new metadata property: 0, default.audio.source, Spa:String:JSON, {"name":"alsa_input.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp_6__source"}
(easyeffects:2): easyeffects-DEBUG: 17:50:22.729: pipe_manager.cpp:881 new metadata property: 0, default.video.source, Spa:String:JSON, {"name":"v4l2_input.pci-0000_00_14.0-usb-0_9_1.0"}
(easyeffects:2): easyeffects-DEBUG: 17:50:22.730: pipe_manager.cpp:1491 easyeffects_sink node successfully retrieved with id 122 and serial 255
(easyeffects:2): easyeffects-DEBUG: 17:50:22.730: pipe_manager.cpp:1496 easyeffects_source node successfully retrieved with id 114 and serial 256
(easyeffects:2): easyeffects-DEBUG: 17:51:14.714: pipe_manager.cpp:212 Stream/Output/Audio 108 Firefox has been removed
(easyeffects:2): easyeffects-DEBUG: 17:51:21.765: pipe_manager.cpp:1135 Stream/Output/Audio 108 Firefox with serial 272 has been added
(easyeffects:2): easyeffects-DEBUG: 17:51:21.771: pipe_manager.cpp:1175 Firefox port 112 is connected to bluez_output.40_ED_98_18_E5_CE.a2dp-sink port 80
(easyeffects:2): easyeffects-DEBUG: 17:51:21.771: pipe_manager.cpp:1175 Firefox port 111 is connected to bluez_output.40_ED_98_18_E5_CE.a2dp-sink port 82Anyway, here's the output:
btw, I'm gonna be AFK until tomorrow, sorry.
wwmm
commented
2 years ago Just to be clear, after this, if I close/open YT videos, there are more lines logged. I assume that's in a different thread then.
Yes. We use the multithreaded PipeWire API. So it is normal that some prints related to PipeWire events are still coming. If there is no line about the output_level and the spectrum filters our main thread is probably stuck in a loop where we wait for PipeWire to provide a valid node id. I have never seen before it failing to provide this. It is super strange.
Arthur-D
commented
2 years ago I'm having the same issue of EasyEffects no longer showing a window after the Flatpak got updated.
Version information: Kubuntu 22.04 PipeWire 0.3.48 EasyEffects 6.2.7
wwmm
commented
2 years ago I'm having the same issue of EasyEffects no longer showing a window after the Flatpak got updated. Kubuntu 22.04 PipeWire 0.3.48
So far what all the users reporting this issue have in common is using the Flatpak package in Ubuntu/Kubuntu 22.04 and PipeWire 0.3.48. Maybe the older PipeWire version is somehow related after all.
QLEDHDTV
commented
2 years ago I had the same issue with 0.3.48 version of PipeWire, and so i decided to try and update it to the latest 0.3.56 version, and it worked - EasyEffects window appeared without any issue
vchernin
commented
2 years ago If anyone is able to, it would be good to bisect PipeWire and find the exact commit where newer versions of EasyEffects fail.
PipeWire is supposed to be API stable so this is probably a bug on their part. In the short-term maybe there is a way to workaround this in EasyEffects if we know what broke, maybe use of a newer PipeWire feature somewhere is the problem.
wwmm
commented
2 years ago maybe use of a newer PipeWire feature somewhere is the problem.
As far as I remember this did not happen.
In the short-term maybe there is a way to workaround this in EasyEffects if we know what broke
The only thing I can think of is that the main thread is stuck in the loop that waits for a valid filter id number. If this is the case the "workaround" would be to put a timeout in the loop. But this doesn't really solve the problem. If PipeWire is not being able to properly initialize the filter so it gets to the point where a valid id number exists the filter won't work. And even if for some miracle the filter is actually working without knowing its id number so we can use it EasyEffects will be broken anyway.
markonius
commented
2 years ago Hey, I'll try updating pipewire when I get to work on Monday. However, wouldn't it be an improvement in general to introduce a timeout here? An error message is much better than a frozen process, isn't it?
wwmm
commented
2 years ago However, wouldn't it be an improvement in general to introduce a timeout here? An error message is much better than a frozen process, isn't it?
Assuming this is really what is happening it will be. I will try to remember to add one. I think that at some point in the past I put one there but as it did not seem possible for this operation to fail I removed it.
stevenlafl
commented
2 years ago Having this same problem. Installed gvfs-backends package. Ran the easyeffects flatpak as root. I get a window. However, it of course says Pipewire is not installed because that is a local user run service.
Is the problem permissions issues?
/usr/share/gvfs/remote-volume-monitors:
total 28
drwxr-xr-x 2 root root 4096 Jul 23 12:37 .
drwxr-xr-x 4 root root 4096 Jul 23 12:37 ..
-rw-r--r-- 1 root root 104 May 26 04:27 afc.monitor
-rw-r--r-- 1 root root 103 May 26 04:27 goa.monitor
-rw-r--r-- 1 root root 111 May 26 04:27 gphoto2.monitor
-rw-r--r-- 1 root root 103 May 26 04:27 mtp.monitor
-rw-r--r-- 1 root root 127 May 26 04:27 udisks2.monitorRoot level:
(zenity:17): GVFS-DEBUG: 13:01:20.625: cannot open directory /usr/share/gvfs/remote-volume-monitors: Error opening directory “/usr/share/gvfs/remote-volume-monitors”: No such file or directory
(zenity:17): GLib-GIO-DEBUG: 13:01:20.626: _g_io_module_get_default: Found default implementation local (GLocalVfs) for ‘gio-vfs’
(process:2): easyeffects-DEBUG: 13:01:23.417: easyeffects.cpp:35 easyeffects version: 6.2.7
(process:2): easyeffects-DEBUG: 13:01:23.418: easyeffects.cpp:45 locale directory: /app/share/locale
(easyeffects:2): GVFS-DEBUG: 13:01:23.419: cannot open directory /usr/share/gvfs/remote-volume-monitors: Error opening directory “/usr/share/gvfs/remote-volume-monitors”: No such file or directory
(easyeffects:2): GLib-GIO-DEBUG: 13:01:23.419: _g_io_module_get_default: Found default implementation local (GLocalVfs) for ‘gio-vfs’
(easyeffects:2): GLib-GIO-DEBUG: 13:01:23.420: _g_io_module_get_default: Found default implementation keyfile (GKeyfileSettingsBackend) for ‘gsettings-backend’User level:
(easyeffects:2): GVFS-RemoteVolumeMonitor-DEBUG: 13:04:09.038: Error: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown
(easyeffects:2): GVFS-DEBUG: 13:04:09.038: cannot open directory /usr/share/gvfs/remote-volume-monitors: Error opening directory “/usr/share/gvfs/remote-volume-monitors”: No such file or directory
(easyeffects:2): GVFS-DEBUG: 13:04:09.039: org.gtk.vfs.MountTracker.listMountableInfo call failed: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown (g-dbus-error-quark, 2)
(easyeffects:2): GLib-GIO-DEBUG: 13:04:09.039: _g_io_module_get_default: Found default implementation local (GLocalVfs) for ‘gio-vfs’
** (process:11566): WARNING **: 13:04:09.039: Error writing credentials to socket: Error sending message: Broken pipe
(easyeffects:2): GLib-GIO-DEBUG: 13:04:09.040: _g_io_module_get_default: Found default implementation keyfile (GKeyfileSettingsBackend) for ‘gsettings-backend’FYI I bisected this in PipeWire, EasyEffects starts working at https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/01b4c4fa649207f8b77da2232cbb6773e2b03f4f. @wwmm any ideas?
wwmm
commented
2 years ago FYI I bisected this in PipeWire, EasyEffects starts working at https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/01b4c4fa649207f8b77da2232cbb6773e2b03f4f. @wwmm any ideas?
It is strange that this commit is the turning point. I do not see a reason why this should have an effect in the node id. If the problem was the node not entering the active state it would make sense. But the node id is something that is usually initialized a lot of time before we even try to link our filters.
I also wonder why only the Flatpak package is being hit by this. The fact it is compiled with PipeWire 0.3.41 must be related somehow.
vchernin
commented
2 years ago I also wonder why only the Flatpak package is being hit by this. The fact it is compiled with PipeWire 0.3.41 must be related somehow.
The only package that would usually have any version of the PipeWire daemon on the host is the Flatpak, the rest like Arch would rarely have a different daemon and library version.
I will try bumping the library version in Flatpak to see if that does anything.
sharifm-informatica
commented
2 years ago same issue on ubuntu 22.04 gnome desktop and wayland using flatpak version of easyeffects.
vchernin
commented
2 years ago Changing PipeWire library didn't help, but I managed to successfully bisect to: 048d293a7de5ebdb5ee8677233a012c64f53aba6.
Reverting it fixes this on master when using PipeWire daemon 0.3.48, and PipeWire library 0.3.41. @wwmm what do you think given https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/01b4c4fa649207f8b77da2232cbb6773e2b03f4f is necessary to make the commit work? Is this a bug in PipeWire?
wwmm
commented
2 years ago Changing PipeWire library didn't help, but I managed to successfully bisect to: https://github.com/wwmm/easyeffects/commit/048d293a7de5ebdb5ee8677233a012c64f53aba6.
Really? Then I do not know anymore where our main thread is blocking. I set PW_KEY_NODE_WANT_DRIVER = true hoping it would help to fix another bug that has been impossible to fix. But in the end it was just a false positive and there was no difference in the other bug behavior. When I was about to remove this property from our code I found out that PipeWire was already setting it to true by default https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/d1207422e09f3a4d334a15bcb6ef0421ce2a1e0f so I just left it there.
Based on the date of the commit that set the value to true by default the PipeWire version shipped by Ubuntu is older and probably behaved in a different way than the latest PipeWire releases. In any case I will remove this property from our code. We do not need it.
wwmm
commented
2 years ago In any case I will remove this property from our code.
Done.
vchernin
commented
2 years ago I think this can be closed now, I'll push the fix to flathub stable later.
EasyEffects Version
6.2.7
What package are you using?
Flatpak (Flathub)
Distribution
Ubuntu 22.04
Describe the bug
flatpak run com.github.wwmm.easyeffects.Expected Behavior
Window would show.
Debug Log
Debug Log
``` ╰─> flatpak --env=G_MESSAGES_DEBUG=easyeffects run com.github.wwmm.easyeffects 2>&1 You have PipeWire 0.3.48 installed This is newer or the same as PipeWire 0.3.41 required to run EasyEffects (process:2): easyeffects-DEBUG: 10:12:11.581: easyeffects.cpp:35 easyeffects version: 6.2.7 (process:2): easyeffects-DEBUG: 10:12:11.582: easyeffects.cpp:45 locale directory: /app/share/locale (easyeffects:2): easyeffects-DEBUG: 10:12:11.589: presets_manager.cpp:72 system input presets directory: "/app/etc/xdg/easyeffects/input"; (easyeffects:2): easyeffects-DEBUG: 10:12:11.589: presets_manager.cpp:72 system input presets directory: "/etc/easyeffects/input"; (easyeffects:2): easyeffects-DEBUG: 10:12:11.589: presets_manager.cpp:72 system input presets directory: "/etc/xdg/easyeffects/input"; (easyeffects:2): easyeffects-DEBUG: 10:12:11.589: presets_manager.cpp:75 system output presets directory: "/app/etc/xdg/easyeffects/output"; (easyeffects:2): easyeffects-DEBUG: 10:12:11.589: presets_manager.cpp:75 system output presets directory: "/etc/easyeffects/output"; (easyeffects:2): easyeffects-DEBUG: 10:12:11.589: presets_manager.cpp:75 system output presets directory: "/etc/xdg/easyeffects/output"; (easyeffects:2): easyeffects-DEBUG: 10:12:11.589: presets_manager.cpp:215 user presets directory already exists: /home/myname/.var/app/com.github.wwmm.easyeffects/config/easyeffects/ (easyeffects:2): easyeffects-DEBUG: 10:12:11.589: presets_manager.cpp:215 user presets directory already exists: /home/myname/.var/app/com.github.wwmm.easyeffects/config/easyeffects/input (easyeffects:2): easyeffects-DEBUG: 10:12:11.589: presets_manager.cpp:215 user presets directory already exists: /home/myname/.var/app/com.github.wwmm.easyeffects/config/easyeffects/output (easyeffects:2): easyeffects-DEBUG: 10:12:11.589: presets_manager.cpp:215 user presets directory already exists: /home/myname/.var/app/com.github.wwmm.easyeffects/config/easyeffects/autoload/input (easyeffects:2): easyeffects-DEBUG: 10:12:11.589: presets_manager.cpp:215 user presets directory already exists: /home/myname/.var/app/com.github.wwmm.easyeffects/config/easyeffects/autoload/output (easyeffects:2): easyeffects-DEBUG: 10:12:11.724: pipe_manager.cpp:1398 compiled with PipeWire: 0.3.41 (easyeffects:2): easyeffects-DEBUG: 10:12:11.724: pipe_manager.cpp:1399 linked to PipeWire: 0.3.41 (easyeffects:2): easyeffects-DEBUG: 10:12:11.725: pipe_manager.cpp:1366 core version: 0.3.48 (easyeffects:2): easyeffects-DEBUG: 10:12:11.725: pipe_manager.cpp:1367 core name: pipewire-0 (easyeffects:2): easyeffects-DEBUG: 10:12:11.726: pipe_manager.cpp:1280 found metadata: settings (easyeffects:2): easyeffects-DEBUG: 10:12:11.726: pipe_manager.cpp:1135 Audio/Sink 43 easyeffects_sink with serial 148 has been added (easyeffects:2): easyeffects-DEBUG: 10:12:11.726: pipe_manager.cpp:1135 Audio/Source/Virtual 48 easyeffects_source with serial 149 has been added (easyeffects:2): easyeffects-DEBUG: 10:12:11.727: pipe_manager.cpp:1491 easyeffects_sink node successfully retrieved with id 43 and serial 148 (easyeffects:2): easyeffects-DEBUG: 10:12:11.728: pipe_manager.cpp:1496 easyeffects_source node successfully retrieved with id 48 and serial 149 ```
Additional Information
Ubuntu 22.04 is using Wayland if it makes a difference.