search

wwmm / easyeffects

Limiter, compressor, convolver, equalizer and auto volume and many other plugins for PipeWire applications
GNU General Public License v3.0
6.22k stars 265 forks source link

DeepFilter: Missing translations #2662

Open Digitalone1 opened 9 months ago

Digitalone1 commented 9 months ago

The translations for this new plugin are missing. The ui builder has not been added to the files to be translated. I think It should be added also the C++ file where is present the status massage for the missing plugin/ladspa wrapper (similar to RNNoise).

wwmm commented 9 months ago

The ui builder has not been added to the files to be translated.

Yes.

I think It should be added also the C++ file where is present the status massage for the missing plugin/ladspa wrapper (similar to RNNoise).

The rnnoise file is there because it does direct calls to _() for the translation strings. I do not remember deepfilternet code doing that.

Digitalone1 commented 9 months ago

The rnnoise file is there because it does direct calls to _() for the translation strings. I do not remember deepfilternet code doing that.

Really? I saw a message like the one for RNNoise when I didn't have the deepfilter plugin from AUR installed.

wwmm commented 9 months ago

I saw a message like the one for RNNoise when I didn't have the deepfilter plugin from AUR installed.

I do not remember exactly where in the code the message dialog is loaded. At least direct calls to _() with strings to be translated inside it I did not see.

Digitalone1 commented 9 months ago

I do not remember exactly where in the code the message dialog is loaded. At least direct calls to _() with strings to be translated inside it I did not see.

I will try to make a search.

Digitalone1 commented 9 months ago

The rnnoise file is there because it does direct calls to _() for the translation strings. I do not remember deepfilternet code doing that.

I think deepfilter is calling this: https://github.com/wwmm/easyeffects/blob/master/src/ui_helpers.cpp#L72

So it should be ok. Maybe you want to make a custom message for deepfilter like it's done for rnnoise here? https://github.com/wwmm/easyeffects/blob/master/src/ui_helpers.cpp#L76

wwmm commented 9 months ago

Maybe you want to make a custom message for deepfilter like it's done for rnnoise here?

Yes. They are in an identical situation.