search

wwmm / easyeffects

Limiter, compressor, convolver, equalizer and auto volume and many other plugins for PipeWire applications
GNU General Public License v3.0
6.55k stars 270 forks source link

[Feature Request] Implement new Auto Gain tool by LSP Plugins #2664

Open p-chan5 opened 1 year ago

p-chan5 commented 1 year ago

Hi guys! I was testing this plugin included in version 1.2.12 of LSP Plugins. It has more options and I think that can be a good option. However, I know you're working on #2533 so I think this could wait longer (maybe add it to the roadmap).

I suppose it would also be good to discuss it since there could be advantages and disadvantages to doing so.

wwmm commented 1 year ago

I suppose it would also be good to discuss it since there could be advantages and disadvantages to doing so.

I looked at its demonstration video and it felt more like something to use when producing music in a DAW. It did not feel like it can replace our current autogain.

LebedevRI commented 1 year ago

I think the one thing missing from the LSP autogain is Integrated loudness tracking. There's also the lack of being able to specify the Reference, but that can be mimicked via the Fall/Grow controls. So yeah, i agree i don't think it can //replace// the current easyeffect's autogain plugin, and i'm not sure there's interest in providing multiple variants of a plugin?

wwmm commented 1 year ago

So yeah, i agree i don't think it can //replace// the current easyeffect's autogain plugin, and i'm not sure there's interest in providing multiple variants of a plugin?

I think that is the key point. For example I think we have too many noise reduction filters. But in this case it is not hard to find a situation where one plugin is capable of getting the job done while the others fail miserably. So in this situation adding another plugin is the only way to improve the results. But I do not see in the autogain case what would be the advantage of adding another one that behaves in a similar way but with different controls. Maybe for music producers there is a point. But from the general purpose of maintaining the overall volume in the same level I do not see the need.

sadko4u commented 1 year ago

There's also the lack of being able to specify the Reference, but that can be mimicked via the Fall/Grow controls.

You can send the reference signal to the sidechain input of the sidechain version:

Additional sidechain input allows to gain the control over the loudness of the output in two different modes:

  • Control - the loudness level of the sidechain signal is measured, then the corresponding gain correction is computed to match the loudness of the sidechain signal to the desired loudness level, and the computed gain is applied to the original track.
  • Match - the loudness level of the sidechain signal is measured, then the measured loudness is interpreted as a desired loudness level. After that, the loudness of the input signal is measured, then the corresponding gain correction is computed to match the loudness level of the input signal to the loudness level of the sidechain signal.

https://lsp-plug.in/?page=manuals&section=sc_autogain_stereo

LebedevRI commented 1 year ago

There's also the lack of being able to specify the Reference, but that can be mimicked via the Fall/Grow controls.

You can send the reference signal to the sidechain input of the sidechain version:

Additional sidechain input allows to gain the control over the loudness of the output in two different modes:

  • Control - the loudness level of the sidechain signal is measured, then the corresponding gain correction is computed to match the loudness of the sidechain signal to the desired loudness level, and the computed gain is applied to the original track.
  • Match - the loudness level of the sidechain signal is measured, then the measured loudness is interpreted as a desired loudness level. After that, the loudness of the input signal is measured, then the corresponding gain correction is computed to match the loudness level of the input signal to the loudness level of the sidechain signal.

https://lsp-plug.in/?page=manuals&section=sc_autogain_stereo

That is an overly overloaded term, yes. I was talking about the current meaning for the Reference term in the existing Autogain filter in EE: https://github.com/wwmm/easyeffects/blob/320d3d57ff34dd11440f6b11398895fb0fff5243/data/ui/autogain.ui#L114-L133

LebedevRI commented 1 year ago

(... IOW being able to completely selectively disable short-term / medium-term terms)

p-chan5 commented 1 year ago

I think including two auto-gain plugins is not a bad idea. You could get different results with both. This decision also depends on the development team, that is, the approach they want to give to EasyEffects. Maybe this plugin can be called Advanced Autogain or something like that...

Whatever your decision I will respect it; It was just an idea I had at the moment :)