search

wwmm / easyeffects

Limiter, compressor, convolver, equalizer and auto volume and many other plugins for PipeWire applications
GNU General Public License v3.0
6.13k stars 265 forks source link

Migration to Adaptive Dialogs #3008

Open Digitalone1 opened 3 months ago

Digitalone1 commented 3 months ago

In Libadwaita 1.6 some widgets will be deprecated:

https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1.5/migrating-to-adaptive-dialogs.html

Libadwaita 1.5 introduces AdwDialog and replacements for AdwMessageDialog, AdwPreferencesWindow and AdwAboutWindow that derive from it.

While the old widgets are not deprecated yet, they will be in the next release.

To use AdwDialog, your parent window must be an instance of either AdwWindow or AdwApplicationWindow. You should migrate to these widgets if you’re still using GtkWindow or GtkApplicationWindow, respectively.

Stop using window titlebar, instead, create an AdwToolbarView and add the titlebar to it as a top bar. Set the window child as the toolbar view content. Set the toolbar view as the AdwWindow:content property on the window.

If you have GtkSearchBar, GtkActionBar etc in a GtkBox, move them to the toolbar view as well as top/bottom bars respectively.

Digitalone1 commented 3 months ago

@wwmm if you start the migration, please do it in another branch, otherwise the merge with community presets will be problematic.

wwmm commented 3 months ago

@wwmm if you start the migration, please do it in another branch, otherwise the merge with community presets will be problematic.

Ok. It is unlikely I will have time to look into this before your PR.

Digitalone1 commented 3 months ago

@wwmm please, pin this issue.