wwmm / easyeffects

Limiter, compressor, convolver, equalizer and auto volume and many other plugins for PipeWire applications
GNU General Public License v3.0
6.12k stars 264 forks source link

Improve APO/GraphicEQ import/export #3195

Closed Digitalone1 closed 1 week ago

Digitalone1 commented 1 week ago

And at the last I'd like to point out that I'm a bit skeptical on the use of band-mute in APO import. At the moment the APO OFF value sets the band-mute, but is it really the same? OFF means the band is not processed, so we still hear it, right? Which is different from the muting which is just emitting silence, I guess? Maybe like band gain to -infinite. Maybe it should be better to set band-type on Off when APO OFF is specified. The problem seems that APO does not have a concept of "muting the band". @wwmm What do you think?

github-actions[bot] commented 1 week ago

Workflow failed, but the following artifacts are still available for this pull request:

wwmm commented 1 week ago

Reset band_width also inside on_calculate_frequencies. This seems a good thing to do since band_width affects the band spectrum, but maybe I could be wrong here. @wwmm What do you think?

It has been so long since I thought about this LSP band_width parameter that I do not remember anymore exactly what it is doing. But as far as the on_calculate_frequencies code goes I think it is fine to reset it. It would only be a problem if the bad)width parameter conflicted with the quality value calculated inside on_calculate_frequencies. But I think this was not the cause.

The problem seems that APO does not have a concept of "muting the band". @wwmm What do you think?

Hum... I think that we probably should set them to OFF.

Digitalone1 commented 1 week ago

@vchernin can you please check this PR importing the APO preset here on Flatpak and see if something weird happens? Thanks.