wwmm / easyeffects

Limiter, compressor, convolver, equalizer and auto volume and many other plugins for PipeWire applications
GNU General Public License v3.0
6.57k stars 270 forks source link

Taskbar and switcher icons not showing up. #331

Closed mthqwork closed 4 years ago

mthqwork commented 6 years ago

This is a problem what I have for months now, but can't figure out what's wrong, as the author also using Arch linux but didnt noticed the issue.

image image

Here is a quick xprop from PE's window: https://pastebin.com/DZTN9pzp

My DE is XFCE 4.12.

The icon shows up properly in launcher and in plank. What could be wrong? Thanks

wwmm commented 6 years ago

If you have this problem with the new and the old icon the only thing that comes to my mind is the fact that the icon is a svg file. Maybe this taskbar does not accepts svg

mthqwork commented 6 years ago

I had problem with old, but have the problem with new also. Yes maybe, i have another apps with broken icons - they also offer svg only icon.

It's stock XFCE4 taskbar.

If I change the app icon in runtime with xseticon to a PNG one, it shows up. Would be great if you include both PNG and SVG icons.

Thanks

wwmm commented 6 years ago

Any ideas about how to offer both versions @zencubic?

mthqwork commented 6 years ago

I have tested this under plasma desktop and it works fine.

However, under MATE 1.20 and XFCE it's still default icon as described.

I hope this will be enhanced soon :)

Thank You

zencubic commented 5 years ago

@wwmm @mthqwork Sorry for the huge delay. I looked a bit into the issue and tested if it would work if I will place a png verision of the icon in every folder in hicolor. Sadly this didn't work out and I have absolutely no idea where XFCE will look for the icons if not there

mthqwork commented 5 years ago

@zencubic I will try to figure it also, maybe we can find a solution for it. Other apps are affected too. So maybe we are not alone.

zencubic commented 5 years ago

IMO XFCE should support SVG icons out of the box. Maybe someone created an issue for that at XFCE. Would be a great discharge for developer of such applications. I didn't even found a documentation from XFCE in which they described where to place the icons. Maybe there's also a freedesktop standard which is responsible for this

TimB87 commented 5 years ago

I tried it with i3bar and i3bar-rust - both don't show the icon for pulseeffects. Can anybody confirm to have this working elsewhere or tell me what package I need to provide to get an taskbar icon?

wwmm commented 4 years ago

Is this still a problem?

TimB87 commented 4 years ago

I still don't get any taskbar icon, so I'd say yes (still using i3status-rust)

wwmm commented 4 years ago

I imagine that the problem is the icon being in the SVG format. But it is so odd that nowadays there are desktops that do not support SVG...

TimB87 commented 4 years ago

I would need to investigate, but I could bet my left shoe blindly that svg icons work on my setup 🤔

TimB87 commented 4 years ago

@wwmm just checked, I do run redshift which only provides svg icons and for that I get a taskbar icon:

i3status-rust

wwmm commented 4 years ago

So it must be something related to the SVG standard being used. Somehow GNOME shows our icon with no problem.

wwmm commented 4 years ago

Maybe our icon is using a SVG feature that is not supported in these taskbar manages but it is on the bigger desktops. But I do not know enough about SVG to verify that.

TimB87 commented 4 years ago

I tried reading into i3status-rust and can't see that it actually handles that part of the bar for i3.. but I would need longer to actually really understand the code, so I am not 100% sure about this.

mthqwork commented 4 years ago

As for taskbar now it's OK at me (XFCE4, Arch, still :) ) As for switcher i can't test it right now, but if I remember good, it's also working.

mthqwork commented 4 years ago

I have checked it and it works well at the switcher too.

wwmm commented 4 years ago

As this issue was solved in XFCE. I will close it. @TimB87 the current code in the master branch has a new icon from the Korla icon theme. If you still have problems in i3status with it feel free to open a new issue.

TimB87 commented 4 years ago

@wwmm will try it out master, hopefully over the weekend. I've been swamped the past days, but if the issue persists i'll open one up to get this resolved/help with my environment that produces those problems.