Closed AroneyS closed 2 weeks ago
Hey,
The OSX one seems to be failing because of conda package issues (transient? There didn't seem to be an issue before), but the x86 tests are failing because of an issue that was introduced/discovered in this branch:
---- tests::test_sharded_contig_input_reads stdout ----
thread 'tests::test_sharded_contig_input_reads' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/assert_cli-0.6.3/src/assert.rs:441:13:
Assertion failed for `cargo run --quiet -- contig -c tests/data/7seqs.reads_for_7.1.fq tests/data/7seqs.reads_for_7.2.fq -r tests/data/shard1.fna tests/data/shard2.fna --sharded`
with: Unexpected stdout
with: Didn't match.
diff=
`` Contig shard1.fna|shard2.fna/7seqs.reads_for_7.1.fq|7seqs.reads_for_7.1.fq Mean
-genome3~random_sequence_length_11001 0.11057869
genome4~random_sequence_length_11002 0.11056851
genome5~seq2 0
genome6~random_sequence_length_11003 0.110558316
genome1~random_sequence_length_11000 0.109943785
genome1~random_sequence_length_11010 0.110487066
genome2~seq1 0
+genome3~random_sequence_length_11001
0.11057869
genome4~random_sequence_length_11002
0.11056851
genome5~seq2
0
genome6~random_sequence_length_11003
0.110558316
genome1~random_sequence_length_11000
0.109943785
genome1~random_sequence_length_11010
0.110487066
genome2~seq1
0
I think that somehow the strobealign sequence IDs have a newline in them, so it messes up the table structure. So maybe a strip() needs to be put in somewhere?
Yeh, that's the odd error that I sent. I think I've fixed it at the printing stage (print_dense_cached_coverage_taker
).
Do I also need to fix it in print_sparse_cached_coverage_taker
?
I think so, yeh
Closes https://github.com/wwood/CoverM/issues/186