wwood / finishm

genome improvement and finishing without further sequencing effort
MIT License
5 stars 2 forks source link

undefined method error #22

Closed ctSkennerton closed 9 years ago

ctSkennerton commented 9 years ago

While rerunning data for issue #17 I got the following error, which may or may not be related

~/local/finishm/bin/finishm roundup --genomes ../../genome_bins/C00003105/PROKKA_08222014.fna --interleaved-fastq C00003105.reads.fastq --gapfill-only --output-directory finishm --max-gapfill-paths 20

<snip>

 INFO finishm 09/02 11:00:15: So far worked with 334336 head node sets, up to distance 17742
 INFO finishm 09/02 11:00:17: So far worked with 334848 head node sets, up to distance 17857
 INFO finishm 09/02 11:00:56: So far worked with 335360 head node sets, up to distance 17971
 INFO finishm 09/02 11:00:58: So far worked with 335872 head node sets, up to distance 18097
 INFO finishm 09/02 11:01:01: So far worked with 336384 head node sets, up to distance 18237
 INFO finishm 09/02 11:01:09: So far worked with 336896 head node sets, up to distance 18384
 INFO finishm 09/02 11:01:11: So far worked with 337408 head node sets, up to distance 18530
 INFO finishm 09/02 11:01:14: So far worked with 337920 head node sets, up to distance 18688
 INFO finishm 09/02 11:01:41: So far worked with 338432 head node sets, up to distance 18844
 INFO finishm 09/02 11:01:42: So far worked with 338944 head node sets, up to distance 19001
 INFO finishm 09/02 11:01:46: So far worked with 339456 head node sets, up to distance 19186
 INFO finishm 09/02 11:01:47: So far worked with 339968 head node sets, up to distance 19412
 INFO finishm 09/02 11:01:48: So far worked with 340480 head node sets, up to distance 19640
 INFO finishm 09/02 11:02:09: So far worked with 340992 head node sets, up to distance 19861
 WARN finishm 09/02 11:02:10: Linking path(s) detected, but cycle also detected. Giving up on this link.
 WARN finishm 09/02 11:02:10: Circular path detected here, not attempting to gapfill
/home/cts/local/finishm/lib/assembly/acyclic_connection_finder.rb:21:in `each': undefined method `each' for nil:NilClass (NoMethodError)
        from /home/cts/local/finishm/lib/finishm/gapfiller.rb:310:in `collect'
        from /home/cts/local/finishm/lib/finishm/gapfiller.rb:310:in `gapfill'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:288:in `block in gapfill_a_scaffold'
        from /home/cts/local/finishm/lib/assembly/input_genome.rb:118:in `block in each_gap_probe_pair'
        from /home/cts/local/finishm/lib/assembly/input_genome.rb:115:in `each'
        from /home/cts/local/finishm/lib/assembly/input_genome.rb:115:in `each_gap_probe_pair'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:283:in `gapfill_a_scaffold'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:167:in `block (5 levels) in run'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:160:in `each'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:160:in `each_with_index'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:160:in `block (4 levels) in run'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:155:in `open'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:155:in `block (3 levels) in run'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:154:in `open'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:154:in `block (2 levels) in run'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:132:in `open'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:132:in `block in run'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:125:in `each'
        from /home/cts/local/finishm/lib/finishm/roundup.rb:125:in `run'
        from /home/cts/local/finishm/bin/finishm:124:in `<main>'
wwood commented 9 years ago

Hey,

Apologies. This bug is fixed in b68dedc so that it doesn't crash, but a better approach to circular paths soon to come, thanks to work from @timbalam

Feel free to reopen this bug if I'm wrong.