wwsalmon / sota.js

d3-based charting library for State of the Academy 2020 and beyond (and before)
https://wwsalmon.github.io/sota.js/
6 stars 0 forks source link

refactor barChart according to lineGraph min/max val parameters #16

Closed wwsalmon closed 4 years ago

wwsalmon commented 4 years ago

probably the other way around, actually -- barChart seems bulkier, but that's because it handles an extra usecase: setting 100% on the scale to the highest value when the input values are percentages. In fact, this use case exactly plays out in the "ethnicity" graph.